Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CMake build to require versions of NCEPLIBS #1028

Open
edwardhartnett opened this issue Aug 28, 2024 · 0 comments
Open

update CMake build to require versions of NCEPLIBS #1028

edwardhartnett opened this issue Aug 28, 2024 · 0 comments
Labels

Comments

@edwardhartnett
Copy link
Collaborator

UPP uses various NCEPLIBS, but does not check for their versions in CMake:

find_package(bacio REQUIRED)
find_package(crtm REQUIRED)
find_package(g2 REQUIRED)
find_package(g2tmpl REQUIRED)
if(BUILD_WITH_GTG)
  find_package(ip REQUIRED)
endif()

Required versions should be listed, and kept up to date. THat is, if UPP changes to require version 3.5.1 of g2, then the build needs to check that and enforce it. The build must be changed whenever that version increases.

This is part of the UPP build's responsibility. Relying on the correct version being present hides problems and makes debugging much harder. Checking the version at build time is normal practice and will ensure that any mismatched versions are caught immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants