Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OOPS and IODA hashes #189

Open
SamuelDegelia-NOAA opened this issue Oct 10, 2024 · 5 comments
Open

Update OOPS and IODA hashes #189

SamuelDegelia-NOAA opened this issue Oct 10, 2024 · 5 comments
Assignees

Comments

@SamuelDegelia-NOAA
Copy link
Contributor

SamuelDegelia-NOAA commented Oct 10, 2024

As discussed in #122, the reduce obs space filter action can significantly reduce the runtime and memory cost of GETKF. But there is currently a bug in OOPS related to the order that the linear and nonlinear h(x) quantities are initialized. This bug leads to a crash when using reduce obs space for GETKF. A PR was just merged to fix this bug. As such, we will need to update the OOPS hash to make use of this filter action. Additionally, I tested the branch in the OOPS PR and found that we will also need to update the IODA hash at the same time.

@hu5970
Copy link
Contributor

hu5970 commented Oct 10, 2024

@SamuelDegelia-NOAA Thanks for bring this issue up. Hongli and Junjun are working on sync latest JEDI-bundle repositories to RDASApp.

@SamuelDegelia-NOAA
Copy link
Contributor Author

SamuelDegelia-NOAA commented Oct 10, 2024

Thanks @hu5970, glad to hear that this is being worked on.

@guoqing-noaa
Copy link
Collaborator

link to issue #154

@guoqing-noaa
Copy link
Collaborator

@SamuelDegelia-NOAA The PR you mentioned is too new and mpasjedi.v3.0.1 did not include that commit.
The latest commit of OOPS is at:

commit d77217323bbbd02ea41049fe1bd339f24a64f177 (HEAD)
Author: Tom Hill <[email protected]>
Date:   Fri Aug 30 00:01:50 2024 +0100

The latest commit of IODA is at:

commit d49ed17e115f5d7ff3310cd1dfe4798c10aa03db (HEAD)
Author: Francois Hebert <[email protected]>
Date:   Mon Sep 9 17:06:03 2024 -0600

    Fix missing include (#1333)

I think the best way forward is that we merge PR #193 first and then you can continue working on this issue. Is that okay for you? Thanks!

@SamuelDegelia-NOAA
Copy link
Contributor Author

That's no problem! We can update it at a later date - no rush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants