Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

degrib2 tests are failing on Intel and Windows because of differences in calculated averages #540

Open
edwardhartnett opened this issue Oct 30, 2024 · 1 comment · May be fixed by #544
Open
Assignees
Labels
test Testing is important!

Comments

@edwardhartnett
Copy link
Contributor

degrib2 tests are failing on Intel and Windows because of differences in calculated averages

For example:

399c399
< ( PARM= SWDIR ) :  MIN=               0.09999999 AVE=             219.31314087 MAX=             359.94000244
---
> ( PARM= SWDIR ) :  MIN=               0.09999999 AVE=             219.31278992 MAX=             359.94000244

Testing degrib2 is fraught with difficulties when comparing text output. What we need is something (snippet of sed? python?) to get rid of the 3rd decimal onward.

(Or, better still, add a flag to degrib2 which causes output to be rounded, then use that for testing.)

@edwardhartnett edwardhartnett added the test Testing is important! label Oct 30, 2024
@edwardhartnett edwardhartnett self-assigned this Oct 30, 2024
@edwardhartnett edwardhartnett linked a pull request Oct 31, 2024 that will close this issue
@edwardhartnett
Copy link
Contributor Author

OK, turns out I already have a utility function to compare two degrib2 outputs and check within tolerances. I just have to remove the two old tests that still use a diff for this, but those tests are reproduced already using the new method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Testing is important!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant