Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSI for RRFS does not build without warning prints #751

Closed
MatthewPyle-NOAA opened this issue Jun 4, 2024 · 5 comments · Fixed by #753
Closed

GSI for RRFS does not build without warning prints #751

MatthewPyle-NOAA opened this issue Jun 4, 2024 · 5 comments · Fixed by #753
Assignees
@ShunLiu-NOAA

Comments

@MatthewPyle-NOAA
Copy link

NCO has been getting stricter about codes compiling cleanly, without warnings. I see warning prints, but limited to a single routine (src/enkf/observer_fv3reg.f90), that are of this type:

/lfs/h2/emc/lam/noscrub/Matthew.Pyle/rrfs-workflow_warnings/sorc/gsi/src/enkf/observer_fv3reg.f90(24): warning #6843: A dummy argument with an explicit INTENT(OUT) declaration is not given an explicit value.   [IX]
subroutine setup_linhx(rlat, rlon, time, ix, delx, ixp, delxp, iy, dely,  &
-----------------------------------------^

Would like to see this item cleaned up well ahead of code delivery for the RRFS - hopefully a straightforward item to correct.
@MatthewPyle-NOAA MatthewPyle-NOAA mentioned this issue Jun 4, 2024
Open
@ShunLiu-NOAA
Copy link
Contributor

@MatthewPyle-NOAA I will take a look at this issue.

@MatthewPyle-NOAA
Copy link
Author

Thanks @ShunLiu-NOAA

@ShunLiu-NOAA ShunLiu-NOAA self-assigned this Jun 5, 2024
@ShunLiu-NOAA ShunLiu-NOAA mentioned this issue Jun 7, 2024
Merged
9 tasks
@RussTreadon-NOAA RussTreadon-NOAA linked a pull request Jun 13, 2024 that will close this issue
Initialize variables to avoid the warning message when compiling #753
Merged
9 tasks
@RussTreadon-NOAA
Copy link
Contributor

@ShunLiu-NOAA , what is the status of this issue?

@ShunLiu-NOAA
Copy link
Contributor

I will work on regression test and update my PR.

@RussTreadon-NOAA
Copy link
Contributor

Thank you, @ShunLiu-NOAA

hu5970 pushed a commit that referenced this issue Oct 1, 2024
@ShunLiu-NOAA
Initialize variables to avoid the warning message when compiling (#753)
665f9b4 
This PR is to initialize variables in observer_fv3reg.f90 to avoid the warning message when compiling.
The change will update regional EnKF excutable. However, the current regression test can't identify the changes in regional EnKF mode. The difference between before and after this update is that no warning message appears when compiling regional EnKF.

This PR is to address #751

**Type of change**
- [x] Bug fix (non-breaking change which fixes an issue)

**Checklist**
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShunLiu-NOAA ShunLiu-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initialize variables to avoid the warning message when compiling ShunLiu-NOAA/GSI
3 participants
@ShunLiu-NOAA @RussTreadon-NOAA @MatthewPyle-NOAA