Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance plotting download stats #576

Merged
merged 10 commits into from
Jan 17, 2025

Conversation

marabuuu
Copy link
Collaborator

@marabuuu marabuuu commented Jan 7, 2025

Hi @haesleinhuepf,

this PR closes #334 by modifying the plotting of our download statistics

It would be great if you could add authors I forgot to mention in authors.py. I introduced this file to compare "our" ressources better to "others".

Furthermore, I added some of the visualisations to the statistics section in appendix.
For more details, see the corresponding Issue #334.

Feel free to let me know if you'd like any changes to these plots—I’ll be happy to incorporate them! 🌞

Best,
Mara

@marabuuu marabuuu requested a review from haesleinhuepf January 7, 2025 11:12
@haesleinhuepf
Copy link
Member

haesleinhuepf commented Jan 17, 2025

Hi @marabuuu ,

looks all good now! Two things I changed.

  • I didn't like the authors.py file in the root folder. I moved it to /scripts/
  • I added little code in authors.py so that the author "Mara Lampert" and "Lampert, Mara" are recognized as the same person. It remains a workaround, but improves the situation a bit. A general solution might be a huge effort.

@haesleinhuepf haesleinhuepf merged commit 9c7763c into NFDI4BIOIMAGE:main Jan 17, 2025
1 of 2 checks passed
@marabuuu
Copy link
Collaborator Author

Thank you for your changes and the hints!

@marabuuu marabuuu deleted the plotting-download-stats branch January 17, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend plotting of download statistics
2 participants