Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve version dependent configuration changes #246

Open
widhalmt opened this issue Aug 23, 2023 · 0 comments
Open

Solve version dependent configuration changes #246

widhalmt opened this issue Aug 23, 2023 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@widhalmt
Copy link
Member

In this collection, elastic_release is an integer, not a version. We have a version variable, that's not always used and can be filled with latest.

So checks like a5c88d4 are very helpful bon't won't work with the current implementation.

There could be a combined solution for this issue and #236 . So set a variable that contains the actual or desired version and then use it for checks like the one in jvm.options. For now I have to deactivate the checks because they create illegal code for version 7.

@widhalmt widhalmt added the bug Something isn't working label Aug 23, 2023
@widhalmt widhalmt added this to the 1.0.0 milestone Aug 23, 2023
widhalmt added a commit that referenced this issue Aug 23, 2023
This is a more serious problem. I opened a separate issue for it: #246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant