From a49a72fc1894c78143158235c971fec3db53f185 Mon Sep 17 00:00:00 2001
From: jaswinder6991 <jassmultani2@gmail.com>
Date: Tue, 30 Jul 2024 13:41:33 +0530
Subject: [PATCH] fix: required deposit fix when available storage is higher
 than needed

---
 .../calculateRequiredDeposit/calculateRequiredDeposit.test.ts | 4 ++--
 .../calculateRequiredDeposit/calculateRequiredDeposit.ts      | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/utils/calculateRequiredDeposit/calculateRequiredDeposit.test.ts b/src/utils/calculateRequiredDeposit/calculateRequiredDeposit.test.ts
index 0765058..2fd1bbb 100644
--- a/src/utils/calculateRequiredDeposit/calculateRequiredDeposit.test.ts
+++ b/src/utils/calculateRequiredDeposit/calculateRequiredDeposit.test.ts
@@ -109,12 +109,12 @@ describe('calculateRequiredDeposit()', () => {
         data,
         storageBalance: {
           available: BigInt(storageCostOfData.plus('1').toFixed()),
-          total: BigInt(storageCostOfData.minus('1').toFixed()),
+          total: BigInt(storageCostOfData.plus('10').toFixed()),
         },
       });
 
       // assert
-      expect(result.toFixed()).toBe('1');
+      expect(result.toFixed()).toBe('0');
     });
   });
 });
diff --git a/src/utils/calculateRequiredDeposit/calculateRequiredDeposit.ts b/src/utils/calculateRequiredDeposit/calculateRequiredDeposit.ts
index 75ff1ce..c40afd9 100644
--- a/src/utils/calculateRequiredDeposit/calculateRequiredDeposit.ts
+++ b/src/utils/calculateRequiredDeposit/calculateRequiredDeposit.ts
@@ -48,5 +48,5 @@ export default function calculateRequiredDeposit({
   // if the storage deposit available is less than the cost of storage, use the difference as the required deposit
   return storageDepositAvailable.lt(storageCostOfData)
     ? storageCostOfData.minus(storageDepositAvailable)
-    : new BigNumber(ONE_YOCTO);
+    : new BigNumber('0');
 }