Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction link column to history tables (Payments, Stake Delegation, etc) #92

Open
8 tasks
FREZZZBE opened this issue Oct 24, 2024 · 6 comments
Open
8 tasks
Labels
enhancement New feature or request

Comments

@FREZZZBE
Copy link
Collaborator

FREZZZBE commented Oct 24, 2024

Dependency

This has a dependency on #157.

Background

Currently, the history table show funded payments. However, there is no link or reference to the actual transaction on near blocks, which makes it hard to find more details if needed.

Feedback from Luca (NF Finance):

Would be helpful that when a transactions concludes the link to the onchain action would be shown directly, or if there was an easy way to extract the link to the onchain action without having to go through extra steps with near explorer

User Story

As an user, I want to have a visible link to funded payment requests (e.g. nearblocks) so that I can find it quickly and easily copy the URL.

Acceptance Criteria

  • Add "Transaction" column to the Payments > History table with a link to the transaction (e.g. nearblock)
  • The settings/filter button should show this new Payment History column. User should have the ability to turn it on or off, similar to other columns.
  • Same for Asset Exchange history
  • Same for Stake Delegation history
  • Same for Settings Reqests history
  • There is an arrow icon and copy icon next to each transaction link
    • The arrow icon opens the transaction
    • The copy icon copy the URL to the transaction

Mockups

'Transactin' colum with link to near block ar Payments history: Figma

Add tha same column for all transactction histories

@FREZZZBE FREZZZBE converted this from a draft issue Oct 24, 2024
@FREZZZBE FREZZZBE added the enhancement New feature or request label Oct 24, 2024
@FREZZZBE
Copy link
Collaborator Author

@ori-near

@ori-near
Copy link

ori-near commented Oct 24, 2024

Thank you @FREZZZBE for capturing this user feedback quickly and outlining a solution. It seems like this was a missed requirement that we had in the original mockups. But upon a closer look – do we want to give the user the ability to also quickly copy the URL? Or just click on it? Right now in the design it looks like there will only be a way to open the link, which might be sufficient. Perhaps we clarify this with the user.

Image

Also, I made a couple of adjustments to the user story / AC.

@ori-near ori-near changed the title Dev: Add link to near explorer for executed transactions Dev: Add transaction link column to Payment History table Oct 24, 2024
@FREZZZBE
Copy link
Collaborator Author

FREZZZBE commented Oct 24, 2024

@ori-near

It seems like this was a missed requirement that we had in the original mockups.

I also included it my reversion of design. I made this mockup long time ago. We skip it in dev for some reason.

do we want to give the user the ability to also quickly copy the URL?

Good point. Pretty sure it would be useful for some users

Image

@Megha-Dev-19
Copy link
Collaborator

We can add it only after indexer is created, since we don’t get this information from the contract. So we will have to store it ourselves.

@ori-near
Copy link

ori-near commented Dec 4, 2024

Hi @Megha-Dev-19 – is this thing ready to work on or are we still waiting for @Tguntenaar to finalize his indexer work? BTW I updated the AC to reflect the latest solution @FREZZZBE presented above. Can you confirm the ticket looks good to you?

@Megha-Dev-19
Copy link
Collaborator

here is the epic for the sputnik indexer

@ori-near ori-near changed the title Dev: Add transaction link column to Payment History table Add transaction link column to history tables (Payments, Stake Delegation, etc) Jan 22, 2025
@ori-near ori-near marked this as a duplicate of #108 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants