Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings > Voting Threshold] Prevent user from updating the Vote permission group to 0 votes? #245

Open
2 tasks
ori-near opened this issue Jan 23, 2025 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ori-near
Copy link

Hi @Megha-Dev-19 / @FREZZZBE – should a user be able to update the Vote permission group number of votes to 0? Wouldn't this lead to a terrible situation where a team can lock themselves out of voting? If so, we should complete the ticket below.


User Story

As a user, I want to be prevented from changing the voting policy in such a way that would lock my team out being able to vote so that we can always perform actions on our treasury.

Acceptance Criteria

  • If a user changes the Number of votes to 0 for the Vote Permission groups, show red message and disable the Submit Request button
  • Warning Message: A minimum of 1 vote is required
@ori-near ori-near added the enhancement New feature or request label Jan 23, 2025
@ori-near ori-near moved this from 🆕 Triage to 📋 Backlog in 🚀 DevHub Products Jan 23, 2025
@Tguntenaar Tguntenaar self-assigned this Jan 23, 2025
@Tguntenaar Tguntenaar moved this from 📋 Backlog to 🏗 In progress in 🚀 DevHub Products Jan 23, 2025
@FREZZZBE
Copy link
Collaborator

FREZZZBE commented Jan 23, 2025

@ori-near I tested the 0 voting threshold, and it functions identically to the 1 for me. I don’t believe it’s necessary to add this validation if it works fine.

@ori-near
Copy link
Author

@FREZZZBE Good to hear that we still maintain 1 minimum ... I still think we should just add a simple form validation (similar to the one when you try to enter a number greater than the total number of members) ... since there's no point to allow the user to go through a useless transaction that doesn't work.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏗 In progress
Development

No branches or pull requests

3 participants