Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the permissions issue #246

Open
wants to merge 12 commits into
base: staging
Choose a base branch
from
Open

Conversation

Megha-Dev-19
Copy link
Collaborator

@Megha-Dev-19 Megha-Dev-19 commented Jan 23, 2025

Resolves #242

  • Added more permissions to policy for 'Manage Members'.
  • Increased the 'Processing your request' timeout, since for different wallets, it takes longer to get approved, so to not show error toast
  • Fixed the issue which Vova faced where the success toast showed w/o any transaction since lastProposalId was null, and disabled submit button even after txn success/ updated the test for it

@Megha-Dev-19
Copy link
Collaborator Author

@race-of-sloths include

@Megha-Dev-19 Megha-Dev-19 marked this pull request as ready for review January 23, 2025 06:47
@race-of-sloths
Copy link

race-of-sloths commented Jan 23, 2025

@Megha-Dev-19 Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: waiting for merge
Reviewer Score
@petersalomonsen 8

Your contribution is much appreciated with a final score of 8!
You have received 80 Sloth points for this contribution

@petersalomonsen received 25 Sloth Points for reviewing and scoring this pull request.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@petersalomonsen
Copy link
Collaborator

@race-of-sloths score 8

Copy link
Collaborator

@petersalomonsen petersalomonsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Megha-Dev-19 . Really love to see the added tests of different proposal types for a factory created instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Settings > Voting Duration] Unable to change voting duration
4 participants