-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support embedded visualization tools #1383
Comments
This feature was requested again recently from the OPC group. From Slack:
|
Related: embedding videos has been requested a number of times (#1730), as well as PDFs |
To add here a +100 we also have such needs from users and we find potentially feasible to propose an easy way to do so for example by allowing inserting iframe code on markdown portal pages, allowing for example to display content if a R shiny app. It seems this functionality is disabled by default in metacatui (or at least using markdown code ok on a markdown web server as codimd is not working on a metacatui portal markdown page). |
@yvanlebras we fully agree. The blocking issue is that embedding these types of items in HTML introduces security issues such as XSS attacks because portals allow users to embed arbitrary content, including malicious content. Due to this, our markdown processors strip all script, object, embed, iframe, and similar tags to prevent these security issues. Finding a way to do this securely is key to enabling this feature. Advances in iframe sandboxing in browsers may indeed provide the degree of isolation needed, but it needs research. |
See related discussion on #2212 (duplicate), including:
|
Thank you for updating this topic ! Maybe an ""easy"" manner to do is to propose a whitelist of web domains from which iframe are accepted? Such whitelist would be propose by default with metacatui and potentially editable by sys admin of metacatui local installations ? Is this making sense? |
Markdown renderer: 10-11-2018 version to 21-04-2022 version Issue #1383
- Add a new Showdown extension to allow iFrames from trusted sources - Add a property in the AppModel to store the list of trusted sources - Allow iFrames through the xss filter with limited attributes so that they can be processed by the new Showdown extension - Add the new Showdown extension to the MarkdownView Issue #1383
- Add a new Showdown extension to allow iFrames from trusted sources - Add a property in the AppModel to store the list of trusted sources - Allow iFrames through the xss filter with limited attributes so that they can be processed by the new Showdown extension - Add the new Showdown extension to the MarkdownView Issue #1383
- Add a new Showdown extension to allow iFrames from trusted sources - Add a property in the AppModel to store the list of trusted sources - Allow iFrames through the xss filter with limited attributes so that they can be processed by the new Showdown extension - Add the new Showdown extension to the MarkdownView Issue #1383
Describe the feature you'd like
Add the ability to include some kind of visualization tool in portals (leaflet maps, for example).
Is your feature request related to a problem? Please describe.
We have received this request from a couple of different groups (SASAP, PerCS-Net). The specific request from Ben Jones of PerCS-Net is:
Additional context
From slack, @laurenwalker remarked:
The text was updated successfully, but these errors were encountered: