Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server tests to travis #32

Open
averagehat opened this issue Sep 2, 2015 · 6 comments
Open

Add server tests to travis #32

averagehat opened this issue Sep 2, 2015 · 6 comments
Assignees

Comments

@averagehat
Copy link
Collaborator

The logic to start server (running make) could happen in .travis.yml or within a robot test.

This will add some time to the tests as it takes some time to download solr, I don't think that we will hit memory limits on travis.

Related to #17

@lianyi
Copy link
Collaborator

lianyi commented Sep 3, 2015

That would be really cool to include the test in at least one of them, perhaps robot test first if that's easier. It might make a lot of server side testing easier if we later want to increase the converge of testing, or adding new features on solr side.

@averagehat averagehat self-assigned this Sep 3, 2015
@averagehat
Copy link
Collaborator Author

Currently it looks like the the download takes a long time, althought he problem may be in the script. We can get around Travis choking the build if it's longer than 10 minutes, although I'd rather have our builds be shorter.
https://travis-ci.org/NCBI-Hackathons/seqr/builds/78597840

@lianyi
Copy link
Collaborator

lianyi commented Sep 4, 2015

Right, the downloading of whole solr dist might be a waste of time and bandwidth for every build. Maybe we can skip the server test in travis for now? The "robot" seems enough to cover those tests.

@averagehat
Copy link
Collaborator Author

I think the way to approach this is to include the solr distribution in our repo

@lianyi
Copy link
Collaborator

lianyi commented Sep 22, 2015

Was the solr dist download the blocking issue?

-----Original Message-----
From: Mike Panciera [[email protected]:[email protected]]
Sent: Tuesday, September 22, 2015 06:40 PM Eastern Standard Time
To: NCBI-Hackathons/seqr
Cc: Han, Lianyi (NIH/NLM/NCBI) [C]
Subject: Re: [seqr] Add server tests to travis (#32)

I think the way to approach this is to include the solr distribution in our repo


Reply to this email directly or view it on GitHubhttps://github.com//issues/32#issuecomment-142441486.

@averagehat
Copy link
Collaborator Author

Yes. Maybe hosting on S3 would be faster somehow too but putting it on the
repo is fine for now I think

On Tue, Sep 22, 2015 at 6:49 PM, Lianyi [email protected] wrote:

Was the solr dist download the blocking issue?

-----Original Message-----
From: Mike Panciera [[email protected]<mailto:
[email protected]>]
Sent: Tuesday, September 22, 2015 06:40 PM Eastern Standard Time
To: NCBI-Hackathons/seqr
Cc: Han, Lianyi (NIH/NLM/NCBI) [C]
Subject: Re: [seqr] Add server tests to travis (#32)

I think the way to approach this is to include the solr distribution in
our repo


Reply to this email directly or view it on GitHub<
https://github.com/NCBI-Hackathons/seqr/issues/32#issuecomment-142441486>.


Reply to this email directly or view it on GitHub
#32 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants