Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching with no beacons results in divide by zero error #48

Open
kennethbruskiewicz opened this issue Aug 24, 2017 · 1 comment
Open
Assignees

Comments

@kennethbruskiewicz
Copy link
Collaborator

If you uncheck all beacons prior to a search, the search attempts to go through but returns a divide by zero error in ListContainer at line 384 (in the loadDataPage function).

Needless to say this is a pathological case, I would both want to make it fail gracefully if a search does go through with no beacons at the very least. We could add a prompt stating that you have no beacons selected, or otherwise force the user to have at least one beacon checked at all times.

@lhannest
Copy link
Member

lhannest commented Jun 4, 2018

No longer a divide by zero error, but it does result in a query appearing in the history box that never finishes. This is much better, but still problematic. Rather, no query should appear in the history box, and a notification should warn the user that all beacons are turned off.

printscreen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants