Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off-by-one error in robocord.job #80

Open
gaurav opened this issue Sep 17, 2020 · 0 comments
Open

Off-by-one error in robocord.job #80

gaurav opened this issue Sep 17, 2020 · 0 comments

Comments

@gaurav
Copy link
Collaborator

gaurav commented Sep 17, 2020

I think there's an off-by-one error in robocord.job, which means that the last block is never processed. It's somewhere in this code:

omnicorp/robocord.job

Lines 21 to 25 in d8fed92

export METADATA_SIZE=$(wc -l < robocord-data/metadata.csv)
export CHUNK_SIZE=$(($METADATA_SIZE/$SLURM_ARRAY_TASK_MAX))
export FROM_ROW=$(($SLURM_ARRAY_TASK_ID * $CHUNK_SIZE))
export UNTIL_ROW=$(($FROM_ROW + $CHUNK_SIZE))
export OUTPUT_FILENAME=robocord-output/result_from_${FROM_ROW}_until_${UNTIL_ROW}.tsv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant