Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output_chrt_NWM exits early on proc 0 if no channel points found #613

Open
danrosen25 opened this issue Apr 6, 2022 · 0 comments
Open

Comments

@danrosen25
Copy link
Collaborator

I stumbled upon this issue because there was a bug in my hydro.namelist configuration that caused the output_chrt_NWM to think there aren't channel points.

https://github.com/NCAR/wrf_hydro_nwm_public/blob/master/trunk/NDHMS/Routing/module_NWM_io.F#L651

Expected Behavior

In the rare case that there aren't channel points either all processes need to return early or all processes need to continue through the end of the subroutine. There are several mpp_land_sync calls in this subroutine and the last sync will wait indefinitely because process 0 has already exited.
https://github.com/NCAR/wrf_hydro_nwm_public/blob/master/trunk/NDHMS/Routing/module_NWM_io.F#L1017

Current Behavior

mpp_land_sync waits indefinitely

Possible Solution

Throwing an error if channel points are zero, skipping over the rest of the output data on proc 0 instead of returning, returning fro all processors.

Steps to Reproduce (for bugs)

  1. I accidentally set the AGGFACTRT to 1 and therefore the domain only looked for channel points in 10% of the Fulldom file, which was probably ocean. And the channel output flag is on.

Your Environment

  • Version of the code used: Latest
  • Operating System and version: Jet, CentOS Linux 7
  • Compiler and version: Intel 18.0.5.274
  • Other relevant information:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants