Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version normalizing does not correctly translate 999.# versions #82

Open
c-suh opened this issue Oct 4, 2023 · 0 comments
Open

Version normalizing does not correctly translate 999.# versions #82

c-suh opened this issue Oct 4, 2023 · 0 comments
Labels
bug Something isn't working icebox open.4.1.2 s.low Low level severity

Comments

@c-suh
Copy link
Contributor

c-suh commented Oct 4, 2023

Checked for duplicates

Yes - I've already checked

🐛 Describe the bug

NOTE: Assumes PR16 has been merged. If not, work off the normalize-version branch.

When I tested the version normalizing functionality with version_ids where the major version is 999 and the minor version is a single digit, the version_id_normalized does not appear as expected. For instance,

  • 999.2 gives 999.0
  • 999.9 gives 999.00006

Functionality seems fine if minor version is not a single digit, or if major version is not 999. For example,

  • 99.90 correctly gives 99.0009
  • 999.90 correctly gives 999.0009
  • 100.20 correctly gives 100.0002
  • 100.2 correctly gives 100.00002

Note: this hasn't been tested with other 3-digit major versions starting with 9 (e.g. 987, 900)


verison-normalized--bug-with-999s

🕵️ Expected behavior

I expected

  • 999.2 gives 999.00002
  • 999.9 gives 999.00009

📜 To Reproduce

Use of a local deployments of this application and Solr are recommended. A note if you already have this that the Solr must be a single shard, so if it isn't already so, you will have to rebuild it accordingly.

  1. Using this XML file (remove the .txt file extension) or something similar where there are at least 2 data products with the same exact lid, edit the values for each instance of version_id
  2. Load the data with your local deployment of registry
  3. Check with your local Solr instance. The URLs will look something like these:

🖥 Environment Info

No response

📚 Version of Software Used

2.3.0-SNAPSHOT

🩺 Test Data / Additional context

NOTE: Assumes PR16 has been merged. If not, work off the normalize-version branch.

test_solr_doc.normalize_versions_bug.xml.txt (remove the .txt file extension to make this into a usable XML file for this application)

🦄 Related requirements

No response

⚙️ Engineering Details

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working icebox open.4.1.2 s.low Low level severity
Projects
Status: ToDo
Development

No branches or pull requests

3 participants