Use bulk default activity arguments and remove getEffectiveActivityArguments calls #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
added
performance
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
requested changes
Jan 30, 2025
| // Get effective arguments for all revisions by coalescing defaults with args supplied in revision | ||
| effectiveRevisionArguments = activityRevisions.map(revision => { | ||
| const defaultArguments = $activityArgumentDefaultsMap[activityType?.name || ''] ?? null; | ||
| defaultArguments.effectiveRevisionArguments = activityRevisions.map(revision => { |
There was a problem hiding this comment.
Should it be setting an effectiveRevisionArguments on the defaultArguments object here?
There was a problem hiding this comment.
Whoops nope, not sure how I ended up with that, good catch. Should just be assigning effectiveRevisionArguments to the right side I believe.
| @@ -20,7 +21,7 @@ | |||
| placement: Placement; | |||
| }; | |||
|
|
|||
| export let rowData: RowData | undefined; | |||
| export let cancellable: boolean = true; | |||
There was a problem hiding this comment.
Can we rename this to explicitly tie it to downloading? e.g. isDownloadCancellable or something like that?
AaronPlave
force-pushed
the
feature/1594/get-effective-directive-arg-rework
branch
from
6e0f20a to
d01275f
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
…e names instead of full activity types
…ncelable but still show progress
AaronPlave
force-pushed
the
feature/1594/get-effective-directive-arg-rework
branch
from
eff39ba to
d960eee
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclusively rely on
getActivityEffectiveArgumentsBulkinstead of the deprecatedgetActivityEffectiveArguments. This entails using the newly made cache of these arguments as well as fetching the set of needed default args for a plan during export. Improves loading performance of activity and span parameters. Additionally improves plan export performance drastically. Previously, plan export performance inversely correlated to the number of activities in the plan since each activity needed a query to get default args. This meant on large plans with thousands of activities, plan export could take tens of minutes if not much longer. With this change, plan export should be nearly instantaneous.Closes #1594