Can you use dependency on MySqlConnector.net (MIT License) instead of MySql.Data( GPL License) #63

himanshukodwani · 2020-08-23T10:11:44Z

MySqlConnector.Net licensing seems to be a better choice for many, also performance-wise it has a slight edge.

adriancs2 · 2020-08-23T10:20:33Z

Thanks for the info. I'll look into this

Relax594 · 2020-12-31T15:38:50Z

I'd appreciate this as well.

adriancs2 · 2021-01-21T11:13:31Z

May I know how do you insert scripts?
The blocks of SQL statements for creating procedures, functions, etc?

In MySql.Data, the code will be something like this:

string text = @"DELIMITER |
CREATE PROCEDURE `proceduresample1`()
    DETERMINISTIC
    COMMENT 'A procedure'
BEGIN
SELECT 'Hello World !';
END |";

using (MySqlConnection conn = new MySqlConnection(ConnectionString))
{
	MySqlScript script = new MySqlScript(conn);
	script.Query = text;
	script.Execute();
}

What is the equivalent of above code if using MySqlConnector.net?

Relax594 · 2021-01-21T11:28:11Z

I've never done that so far sorry.

himanshukodwani · 2021-01-21T12:49:06Z

Hi!! You may look into this discussion: mysql-net/MySqlConnector#382 Best regards Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10 From: Adrian Voo<mailto:[email protected]> Sent: 21 January 2021 16:43 To: MySqlBackupNET/MySqlBackup.Net<mailto:[email protected]> Cc: himanshukodwani<mailto:[email protected]>; Author<mailto:[email protected]> Subject: Re: [MySqlBackupNET/MySqlBackup.Net] Can you use dependency on MySqlConnector.net (MIT License) instead of MySql.Data( GPL License) (#63) May I know how do you insert scripts? The blocks of SQL statements for creating procedures, functions, etc? In MySql.Data, the code will be something like this: string text = @"DELIMITER | CREATE PROCEDURE `proceduresample1`() DETERMINISTIC COMMENT 'A procedure' BEGIN SELECT 'Hello World !'; END |"; using (MySqlConnection conn = new MySqlConnection(ConnectionString)) { MySqlScript script = new MySqlScript(conn); script.Query = text; script.Execute(); script = null; } What is the equivalent code of if using MySqlConnector.net? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#63 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJ7O4IRKJR56MIES52J54LTS3AD6ZANCNFSM4QISV3PQ>.

Memnarch · 2021-01-27T13:48:16Z

Can confirm you can just use a MySQLCommand in MySQLConnector to run multiple things. Using it and was looking for a backup-integration into my software and ended up here ;)

In my buildsystem I create different sql files for either full creating of my schema or patching a schema between to versions of my database-schema. I can simply load my file into a string, put it into a MySQLCommand and run it and it'll work as expected running all the create/alter statements in it.

From that discussion, MySQLScript from Oracle sounds like a hack to fix a designflaw in their MySQLCommand o.o

Flithor · 2021-03-01T01:27:25Z

Well, MySqlConnector.Net not support DELIMITER statement, DELIMITER it's only work with MySqlClient:
mysql-net/MySqlConnector#645
So, consider notify user do not use DELIMITER.

Your sql can remove DELIMITER and code will be:

string text = @"DROP PROCEDURE IF EXISTS`proceduresample1`;

-- DELIMITER |
CREATE PROCEDURE `proceduresample1`()
    DETERMINISTIC
    COMMENT 'A procedure'
BEGIN
    SELECT 'Hello World !';
-- END |
END;

CALL proceduresample1;
";

using (MySqlConnection conn = new MySqlConnection(ConnectionString))
using (MySqlCommand cmd = new MySqlCommand(text, conn))
{
    conn.Open();
    Debug.WriteLine(cmd.ExecuteScalar());
    //Output "Hello World !"
}

JeanRessouche · 2021-09-21T22:40:48Z

News ?

JeanRessouche · 2021-09-21T23:27:20Z

Hi @adriancs2, as i was stuck without it, i made a quick (& maybe dirty) fork supporting it, plus a nuget package.

https://github.com/souchprod/MySqlBackup.Net
https://www.nuget.org/packages/MySqlBackup.NET.MysqlConnector/2.3.4.2

It was mostly about changing the reference to MysqlConnector & using a clone of MysqlScript.
Let me know if you want a PR or if you prefer to implement it yourself your own way.
Once implemented, i will remove my package from Nuget.

adriancs2 · 2021-09-22T07:48:38Z

Hi @souchprod , nice work :)
I have included the 2 additional files ( MySqlScript.cs and MySqlTokenizer.cs ) that done by you and built the DLL. Nice workaround. and thanks.

along with additional for support of MySqlConnector.DLL, I have also added some updates, here are the summary:

[New]

ExportInformation.EnableComment = true. (new option)
Added support for MySqlConnector (MIT)
ExportToFile(), if the directory is not existed. MySqlBackup will attempt to create it.

[Improve]

ImportInfo.ErrorLogFile = true. Now will include the query that causes the error.
ExportToFile = Auto created directory if not exists.
For non delimeter changed query execution, using MySqlCommand in stead of MySqlScript, slightly increase overall import speed.
Minor clean up.

I did some benchmark between MySqlCommand and MySqlScript, and I found that MySqlCommand is slightly faster than MySqlScript. Therefore, for normal execution, I use MySqlCommand, and for routines creation (store procedures, functions, views, triggers, etc...), I use MySqlScript.

Below is the summary of the benchmark:

Database Size: 380MB
CPU: Intel Core i5
RAM: 12GB
Harddisk: Samsung SSD Evo 860

Time(Avr)   Class - DLL
---         ---
57s         mysql.exe (MySqlWorkbench)
1m 5s       MySqlCommand - MySql.Data.DLL
1m 5s       MySqlCommand - MySqlConnector.DLL
1m 5s       MySqlCommand - Devart.Express.MySql.DLL
1m 16s      MySqlScript  - MySql.Data.DLL

I have already released the binaries for MySqlConnector.DLL. You can download it at:
https://github.com/MySqlBackupNET/MySqlBackup.Net/releases

You can also download the specific files here for testing:
MySqlBackupNet.MySqlConnector.DLL(2.3.5).zip

himanshukodwani · 2021-09-22T10:14:23Z

Thanks @souchprod and @adrian Voo for the nice work done. Was looking forward to it since long. Take care guys. Himanshu Kodwani Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows From: Adrian ***@***.***> Sent: 22 September 2021 13:18 To: ***@***.***> Cc: ***@***.***>; ***@***.***> Subject: Re: [MySqlBackupNET/MySqlBackup.Net] Can you use dependency on MySqlConnector.net (MIT License) instead of MySql.Data( GPL License) (#63) Hi @souchprod<https://github.com/souchprod> , nice work :) I have included the 2 additional files ( MySqlScript.cs and MySqlTokenizer.cs ) and built the DLL. Nice workaround. and thanks. along with additional for support of MySqlConnector.DLL, I have also added some updates, here are the summary: [New] * ExportInformation.EnableComment = true. (new option) * Added support for MySqlConnector (MIT) * ExportToFile(), if the directory is not existed. MySqlBackup will attempt to create it. [Improve] * ImportInfo.ErrorLogFile = true. Now will include the query that causes the error. * ExportToFile = Auto created directory if not exists. * For non delimeter changed query execution, using MySqlCommand in stead of MySqlScript, slightly increase overall import speed. * Minor clean up. I did some benchmark between MySqlCommand and MySqlScript, and I found that MySqlCommand is slightly faster than MySqlScript. Therefore, for normal execution, I use MySqlCommand, and for routines creation (store procedures, functions, views, triggers, etc...), I use MySqlScript. Below is the summary of the benchmark: Database Size: 380MB CPU: Intel Core i5 RAM: 12GB Harddisk: Samsung SSD Evo 860 Time(Avr) Class - DLL

…

--- --- 57s mysql.exe (MySqlWorkbench) 1m 5s MySqlCommand - MySql.Data.DLL 1m 5s MySqlCommand - MySqlConnector.DLL 1m 5s MySqlCommand - Devart.Express.MySql.DLL 1m 16s MySqlScript - MySql.Data.DLL I have already released the binaries for MySqlConnector.DLL. You can download it at: https://github.com/MySqlBackupNET/MySqlBackup.Net/releases You can also download the specific files here for testing: MySqlBackupNet.MySqlConnector (v2.3.5).zip<https://github.com/MySqlBackupNET/MySqlBackup.Net/files/7208737/MySqlBackupNet.MySqlConnector.v2.3.5.zip> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#63 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJ7O4ITW3ZIKLHXOPOEUVLLUDGC6BANCNFSM4QISV3PQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

adriancs2 · 2021-09-23T02:05:34Z

Hi @souchprod I would like to upload the new nuget package for MySqlConnector, can you add me as the owner of the package?
https://www.nuget.org/packages/MySqlBackup.NET.MysqlConnector/

JeanRessouche · 2021-09-23T18:30:52Z

HI @adriancs2 , yep i'll search how to do this now, nice to have the changes included in the original repo and glad to see the other improvements

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Can you use dependency on MySqlConnector.net (MIT License) instead of MySql.Data( GPL License) #63

Can you use dependency on MySqlConnector.net (MIT License) instead of MySql.Data( GPL License) #63

himanshukodwani commented Aug 23, 2020

adriancs2 commented Aug 23, 2020

Relax594 commented Dec 31, 2020

adriancs2 commented Jan 21, 2021 •

edited

Loading

Relax594 commented Jan 21, 2021

himanshukodwani commented Jan 21, 2021 via email

Memnarch commented Jan 27, 2021 •

edited

Loading

Flithor commented Mar 1, 2021 •

edited

Loading

JeanRessouche commented Sep 21, 2021

JeanRessouche commented Sep 21, 2021

adriancs2 commented Sep 22, 2021 •

edited

Loading

himanshukodwani commented Sep 22, 2021 via email

adriancs2 commented Sep 23, 2021

JeanRessouche commented Sep 23, 2021

Can you use dependency on MySqlConnector.net (MIT License) instead of MySql.Data( GPL License) #63

Can you use dependency on MySqlConnector.net (MIT License) instead of MySql.Data( GPL License) #63

Comments

himanshukodwani commented Aug 23, 2020

adriancs2 commented Aug 23, 2020

Relax594 commented Dec 31, 2020

adriancs2 commented Jan 21, 2021 • edited Loading

Relax594 commented Jan 21, 2021

himanshukodwani commented Jan 21, 2021 via email

Memnarch commented Jan 27, 2021 • edited Loading

Flithor commented Mar 1, 2021 • edited Loading

JeanRessouche commented Sep 21, 2021

JeanRessouche commented Sep 21, 2021

adriancs2 commented Sep 22, 2021 • edited Loading

himanshukodwani commented Sep 22, 2021 via email

adriancs2 commented Sep 23, 2021

JeanRessouche commented Sep 23, 2021

adriancs2 commented Jan 21, 2021 •

edited

Loading

Memnarch commented Jan 27, 2021 •

edited

Loading

Flithor commented Mar 1, 2021 •

edited

Loading

adriancs2 commented Sep 22, 2021 •

edited

Loading