Ghost changes in commits

[machiav3lli]

In the last I noticed that sometimes GittyUp add changes out of nothing to the staged commits, I wasn't able even to see them in the staged block. Here's the three latest examples:

• Droid-ify: Problematic commit its fix
• OABX: Problematic commit its fix
• OABX: Problematic commit its fix

It's also good to mention that I wasn't able to reproduce it intentionally…

[stefanknotzer]

Assuming 'its fix' is the correction to the staging failure: in every case lines were erroneous deleted? So you had to add the deletions to fix the staging problem?

[machiav3lli]

@stefanknotzer nope, this is what I meant by it being ghost. Nothing happend to the file, but in the commit's diff it showed up, after refreshing it was possible to recommit the missed code.

It's fully random as you can see in the cited commits, sometimes it's a whole file, sometimes it's just couple of lines.

[Murmele]

On which are you working?

[machiav3lli]

AUR's gittyup-git: https://aur.archlinux.org/packages/gittyup-git

[Murmele]

I think I have seen this too.

[Murmele]

In this scenario, add_subdirectory(Spice) does not show if it is staged or not. When opening a different git tool it shows that this line is staged. Maybe it is related to this bug here.

[Murmele]

In this scenario, add_subdirectory(Spice) does not show if it is staged or not. When opening a different git tool it shows that this line is staged. Maybe it is related to this bug here.

Hmm not reproducable anymore

[machiav3lli]

Since my last writing, I had it only once, and still not reproducable. Maybe there's something changed partly fixing it or it's just me being more cautious with each staging and commit.

[ghost]

No in this area nothing changed so the issue is still there

[ghost]

I think it is a missmatch between between staged and unstaged file passed to the Filewidget.

[Murmele]

Seems to be different on windows and on linux. I was able to reproduce it on windows, but on linus the behavior is different

[Murmele]

I have now a reproducable example. Hope i can fix it soon

[machiav3lli]

Ah, nice!

[Murmele]

@machiav3lli
Can you try if you are able to reproduce with the build artifacts from here: #122

[Murmele]

I close it for now. If it happens again, please reopen it

[machiav3lli]

Hm.. it worked just fine till yesterday, when I had it again and till now am unable to reproduce it (Nothing changed, I'm still using the latest dev AUR gittyup-git).

[Murmele]

@machiav3lli I think now I found it :) Can you have a look on the pullrequest and the description there. Maybe you remember if you had a scenario like this.
#172

Please open this issue again if this does not fix you problem

[machiav3lli]

Thanks, I'll do. And please consider refreshing the AUR releases (either update the non-dev gittyup-git or do a formal release)

[Murmele]

I am planning to create a new release next days. Currently we don't support officially AUR releases.

There is a discussion ongoing: #167