Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Removing VR screen buffer in Gecko #1309

Closed
daoshengmu opened this issue Jun 10, 2019 · 3 comments
Closed

Removing VR screen buffer in Gecko #1309

daoshengmu opened this issue Jun 10, 2019 · 3 comments
Labels
bug This issue is a software or functional defect Bugzilla Main activity on this bug is in Bugzilla needinfo Further information is requested size: 2
Milestone

Comments

@daoshengmu
Copy link
Contributor

Current Behavior

We currently ask for an additional buffer to get the AndroidSurfaceTexture from WebGL context. It looks like the gl->Screen() is already been copied the frame result from WebGL framebuffer. We should just use it.

Expected Behavior

Remove VR screen buffer, just us gl->Screen(). I have filed Bug 1558333 to work on.

Possible Solution

Context

Error Logs and Stack Traces

@daoshengmu daoshengmu added Bugzilla Main activity on this bug is in Bugzilla size: 2 labels Jun 10, 2019
@daoshengmu daoshengmu self-assigned this Jun 10, 2019
@philip-lamb philip-lamb added the bug This issue is a software or functional defect label Jun 11, 2019
@jvonitter jvonitter added this to the v1.4 milestone Jul 8, 2019
@jvonitter jvonitter modified the milestones: v1.4, v1.5 Aug 14, 2019
@jvonitter jvonitter modified the milestones: #5 polish, #6 features, Icebox Oct 2, 2019
@philip-lamb philip-lamb added the needinfo Further information is requested label Oct 2, 2019
@philip-lamb
Copy link
Contributor

@daoshengmu Let's chat about the relationship between this bug and the work tracked in https://bugzilla.mozilla.org/show_bug.cgi?id=1537961

@philip-lamb philip-lamb modified the milestones: Icebox, v1.x Oct 2, 2019
@daoshengmu
Copy link
Contributor Author

@daoshengmu Let's chat about the relationship between this bug and the work tracked in https://bugzilla.mozilla.org/show_bug.cgi?id=1537961

According to the review comment at https://phabricator.services.mozilla.com/D34435. It still has some concerns about deadlocks (WebVR using the same texture at the same time of compositor). Therefore, I think we can close this issue, and the following works will be #1429.

@jvonitter
Copy link
Contributor

thanks @daoshengmu !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a software or functional defect Bugzilla Main activity on this bug is in Bugzilla needinfo Further information is requested size: 2
Projects
None yet
Development

No branches or pull requests

3 participants