Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling outlier molecules in match_minima.py #5

Open
vtlim opened this issue Feb 7, 2020 · 2 comments
Open

handling outlier molecules in match_minima.py #5

vtlim opened this issue Feb 7, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@vtlim
Copy link
Member

vtlim commented Feb 7, 2020

On the full benchmark set, while generating plots with match_minima.py using data read in from pickle file, the memory grows exceedingly high (observed > 60 Gb) and is eventually killed.

I am working on identifying high memory use areas using the memory_profiler package with
PYTHONPATH=../ python -m memory_profiler ../match_minima.py -i match.in --cutoff 1.0 --plot --readpickle

@vtlim
Copy link
Member Author

vtlim commented Feb 10, 2020

Issue was traced back to molecules with extremely high disparate energies. For example, in this plot (disregarding the RMSD axis) some GAFF energies are exceedingly high -- 3.5e7 kcal/mol.
image

This particular case is due to GAFF missing a specific vdW parameter for polar hydrogen atoms leading to overlapping atoms. Additional molecules with this issue are here:
image

The solution for this might be to check if any of the FF values compared to the reference method is greater than some cutoff, then skip generating plots for this mol. Cutoff would be arbitrarily defined though, say 1000 kcal/mol?

@vtlim vtlim changed the title memory management in match_minima.py handling outlier molecules in match_minima.py Feb 10, 2020
@vtlim
Copy link
Member Author

vtlim commented Nov 6, 2020

@vtlim vtlim added the enhancement New feature or request label Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant