Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version comparison is failing due to incompatibility between Java snapshot version and PEP 440 #886

Open
davidgamez opened this issue Jan 20, 2025 · 0 comments · May be fixed by #889
Open
Assignees
Labels
bug Something isn't working

Comments

@davidgamez
Copy link
Member

Describe the bug

We are using a very convenient method for comparing versions is two places, 1 2.

Steps/Code to Reproduce

Expected Results

The version is properly parsed and compared.

Actual Results

An exception is raised and the server returns 500 HTTP status

Screenshots

No response

Files used

No response

Additional notes

Proposal fix

Replace the appearance of -SNAPSHOT with .dev0, this is 100% compatible with PEP 440. More info, https://peps.python.org/pep-0440/#developmental-releases

@davidgamez davidgamez added the bug Something isn't working label Jan 20, 2025
@davidgamez davidgamez changed the title Version comparison is failing due to incompatibility Java version and PEP 440 Version comparison is failing due to incompatibility between Java snapshot version and PEP 440 Jan 20, 2025
@davidgamez davidgamez self-assigned this Jan 21, 2025
@davidgamez davidgamez linked a pull request Jan 21, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant