Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset update_interactions method #240

Open
blondered opened this issue Jan 14, 2025 · 1 comment
Open

Dataset update_interactions method #240

blondered opened this issue Jan 14, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@blondered
Copy link
Collaborator

Feature Description

Draft functionality (to be discussed):

update_interactions method of the Dataset accepts:

  • interactions_df : pd.DataFrame
  • method: tp.Literal["add", "replace"]

The main goal is to get old dataset id maps, extend them to new users and items. Then convert new interactions to internal ids and append those new interactions to the old ones.

We have one very important thing to remember: dataset id_map always has hot users (who have interactions) before warm users (who don't have interactions but have features). New hot users should start from the last id that was relevant for the old hot users.
But previously these id belonged to warm users. So warm users will have their ids changed. So user_features array should also be changed. Row numbers in user_features correspond to internal user ids.
Same for items.

In the first PR we can implement just one of the methods.
"add" method should just append new interactions to the old ones. (duplicate user-item pairs will have multiple entries, this will result in their weights summed in user-item matrix)
"replace" method should remove old interactions.

Why this feature?

This allows for incremental training for models that support fit_partial.

Additional context

Discussed here: #176

Updating user and item features should be done in next PRs.

Maybe we should call this method update_data or smth like that to create only one method for interactions and features with optional arguments.

To be discussed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant