[Experimental] Introduce ImplicitBPRWrapper model #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 45 60 +15
Lines 2242 3970 +1728
===========================================
+ Hits 2242 3970 +1728 ☔ View full report in Codecov by Sentry. |
chezou
force-pushed
the
feature/bpr
branch
5 times, most recently
from
1fa6a73 to
2f096b6
Compare
chezou
changed the title
feldlime
reviewed
Dec 12, 2024
blondered
reviewed
Jan 10, 2025
blondered
reviewed
Jan 10, 2025
Fixing the comments Co-authored-by: Daria <[email protected]>
|
I found the RTD error: This is because Poetry no longer supports However, poetry export is not stable enough, and I suggested to change on #227 (comment) |
While using of whitelist/blacklist is not recommended[1], the consistency is preferred. This commit changes the term `allowlist` to `whitelist` in the test file. [1]: https://www.acm.org/diversity-inclusion/words-matter
feldlime
approved these changes
Jan 12, 2025
|
Thanks for the review! Note that I tried to stabilize the test as much as possible e70ef91, however, I see some flakiness presumably due to lack of holding initial random state like rectools-lightfm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #132
As a first step, don't support features at this moment since it requires to additional design for CPU implementation because CPU BPR class is fully Cythonized.
While I tried to keep deterministic for unit tests, BPR updates random states every fit, so I gave up some tests. Some tests may flakey.
Type of change
How Has This Been Tested?
Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.