Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why use crazymax cloudflared repo when cloudflare maintains their own? #247

Open
Johbii opened this issue Dec 21, 2022 · 2 comments · May be fixed by #331
Open

Why use crazymax cloudflared repo when cloudflare maintains their own? #247

Johbii opened this issue Dec 21, 2022 · 2 comments · May be fixed by #331

Comments

@Johbii
Copy link

Johbii commented Dec 21, 2022

Title. Default value is to use the user maintained repo when it is much more reliable to use the official repo.

While there is configuration for changing the repo, there is no configuration for changing container arguments as is necessary for the official docker container to work.

@tupperward
Copy link

tupperward commented Dec 21, 2022

According to the cloudflare/cloudflared documentation, you set the configuration using a configuration.yaml file.

We should be able to do this by creating a ConfigMap with our configuration.yaml data and set it to a volumeMount in the container at the default install path.

We can likely do this with just a short _helper.tpl settings to create this configmap and then mount the data to a volume at the config path only if there is a value that's set. Since Helm evaluates empty strings as Null we should be good there.

I think I can make a branch for this.

@magsol
Copy link

magsol commented Jun 19, 2024

Was there any update on this? I've been having a lot of issues with the crazymax container crashing for no discernible reason over the past week and would love to try something more reliable (or just something else). It's making pihole almost unusable in its entirety.

@mivek mivek linked a pull request Jan 4, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants