Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate plotter and converter #52

Open
chazeon opened this issue Jul 21, 2018 · 2 comments
Open

Seperate plotter and converter #52

chazeon opened this issue Jul 21, 2018 · 2 comments

Comments

@chazeon
Copy link
Member

chazeon commented Jul 21, 2018

Now since the plugin system is almost online as in #51, we could consider move the plotter and the converter to separate packages, and they could have their own CLI command in order to be runnable on supercomputers, and also list qha as an optional dependency, to work as a plugin for QHA.

Supporting 3 styles of CLI command is trival, only ~10 lines of modification as is shown in this commit.


Update: Now #51 is moved to #53.

@singularitti
Copy link
Member

singularitti commented Jul 22, 2018

Now since the plugin system is almost online as in #51, we could consider move the plotter and the converter to separate packages, and they could have their own CLI command in order to be runnable on supercomputers, ...

Agree.

and also list qha as an optional dependency, to work as a plugin for QHA.

Not sure what does this sentence mean, :)

@chazeon
Copy link
Member Author

chazeon commented Jul 22, 2018

and also list qha as an optional dependency, to work as a plugin for QHA.

Not sure what does this sentence mean, :)

Some of the components, such as the plotter or the converter, should be a part of QHA, doesn't have to depend on QHA. Depending on QHA limits their use cases since QHA is not available to be installed everywhere (such as on Habanero or other places where bigfloat could not be installed or Python is not of version 3.6).

But maybe we should put more thoughts on this because some utilities is acuatlly useful for writing those plugins though not being the main part of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants