Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Inserting emoji from emoji menu using enter key does not delete search text in list nodes #35

Open
2 tasks done
C-FWES opened this issue Mar 12, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@C-FWES
Copy link

C-FWES commented Mar 12, 2024

Initial checklist

  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything (or linked relevant results below)

Affected packages and versions

7.3.5

Link to runnable example

https://stackblitz.com/edit/github-xjl3gc?file=components%2FEditor.tsx

Steps to reproduce

  • Create a ordered or unordered list in the editor.
  • Trigger the emoji menu using the : syntax.
  • Press enter to select an emoji.

Expected behavior

Emoji is inserted and the search syntax that was typed, eg. :b is deleted.

Actual behavior

Emoji is inserted but search syntax is not deleted, eg. :be 🐻 . However, if I click on the selected emoji instead of using the enter key, it is inserted without issue. This occurs on both the instance I have running on electron with react and webpack and the linked online example.

Runtime

Firefox, Electron

OS

Windows, macOS

Build and bundle tools

Webpack, Vite

@C-FWES C-FWES added the bug Something isn't working label Mar 12, 2024
@C-FWES C-FWES changed the title Inserting emoji from emoji menu using enter key does not delete search text in list nodes [Bug] Inserting emoji from emoji menu using enter key does not delete search text in list nodes Mar 12, 2024
@quank123wip
Copy link

This works well in online playground, and emoji menu isn't included in this repository, you should debug it your self. However, I think this has something to do with your state.ts, maybe get wrong editor instance?

@Saul-Mirone Saul-Mirone transferred this issue from Milkdown/milkdown Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants