Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] specify a mount node for tooltip #1635

Open
2 tasks done
ylc395 opened this issue Jan 21, 2025 · 0 comments
Open
2 tasks done

[Feature] specify a mount node for tooltip #1635

ylc395 opened this issue Jan 21, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ylc395
Copy link
Contributor

ylc395 commented Jan 21, 2025

Initial checklist

  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything (or linked relevant results below)

Problem

view.dom.parentElement?.appendChild(this.element)

Tooltip and its derived components like Link Tooltip, is always mounted in milkdown container. This is not suitable when milkdown container or its ancestors has style like overflow: hidden:

Image

Solution

We can provide an extra option like mount to specify a mount node, so users can mount tooltip element into a specified element ( for example, document.body).

If this proposal is acceptable, I can submit a PR.

Alternatives

No

@ylc395 ylc395 added the enhancement New feature or request label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants