TODO: Fix critical compatibility issue with PHP v7.4 and higher, due to deprecated behavior of array_key_exists function

[rizdaprasetya]

Summary of issue

as title

Sample PHP error

• CRITICAL Uncaught TypeError: array_key_exists(): Argument #2 ($array) must be of type array, stdClass given in /code/wp-content/plugins/edd-midtrans-gateway/lib/Midtrans/Notification.php:32
  • Thrown when receiving notif & likely breaks notif handling flow

PHP Error Log details

2023-12-06T08:54:52+00:00 CRITICAL Uncaught TypeError: array_key_exists(): Argument #2 ($array) must be of type array, stdClass given in /code/wp-content/plugins/edd-midtrans-gateway/lib/Midtrans/Notification.php:32
Stack trace:
#0 /code/wp-content/plugins/edd-midtrans-gateway/lib/Midtrans/Notification.php(32): array_key_exists('transaction_sta...', Object(stdClass))
#1 /code/wp-content/plugins/edd-midtrans-gateway/midtrans-standard.php(62): Midtrans\Notification->__get('transaction_sta...')
#2 /code/wp-includes/class-wp-hook.php(324): edd_midtrans_notification('')
#3 /code/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters('', Array)
#4 /code/wp-includes/plugin.php(517): WP_Hook->do_action(Array)
#5 /code/wp-content/plugins/edd-midtrans-gateway/midtrans-standard.php(103): do_action('edd_midtrans_no...')
#6 /code/wp-includes/class-wp-hook.php(324): edd_listen_for_midtrans_notification('')
#7 /code/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters(NULL, Array)
#8 /code/wp-includes/plugin.php(517): WP_Hook->do_action(Array)
#9 /code/wp-settings.php(643): do_action('init')
#10 /code/wp-config.php(86): require_once('/code/wp-settin...')
#11 /code/wp-load.php(50): require_once('/code/wp-config...')
#12 /code/wp-blog-header.php(13): require_once('/code/wp-load.p...')
#13 /code/index.php(17): require('/code/wp-blog-h...')
#14 {main}
  thrown in /code/wp-content/plugins/edd-midtrans-gateway/lib/Midtrans/Notification.php on line 32

Reference of issue

• https://stackoverflow.com/questions/69660273/if-array-key-exists-is-deprecated-in-php7-4-then-how-to-use-the-alternative-l
• https://www.php.net/manual/en/migration74.deprecated.php#migration74.deprecated.core.array-key-exists-objects

Line of codes to fix

For example, search for any occurrence of array_key_exists function calls:

• https://github.com/search?q=repo%3AMidtrans%2Fmidtrans-edd+array_key_exists&type=code

Reference of possible fix actions

• veritrans/SNAP-Woocommerce@a3bc8eb

Other

• Current status: postponed with no ETA, waiting for the future maintainer's available bandwidth