-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using lint-staged #1
Comments
ping @StorytellerCZ |
🤔 I'm not sure. If we have a simple bash script that I think is preferable instead of adding additional package. It is also readable in regard what is going on and adjustable. On the other hand it is an extra file to maintain which might not be as bad with an extra package. |
I'm perfectly comfortable with a bash script, however lint-staged is a cross platform solution which will also work for devs working on windows based environments. Yes it's an extra package, but it's also just a dev dependency and wouldn't affect the build at all. |
OK, sounds good. Feel free to push the changes. |
@copleykj The only current problem I see that we currently have StandardJS, which is a problem for lint-staged: |
What about configuring eslint with eslint-plugin-standard? |
Probably the way forward so that we can include Meteor specific rules as well. |
It looks like
preCommit.sh
is basically doing what thelint-staged
package does. Should we consider that instead?The text was updated successfully, but these errors were encountered: