Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate code and docs? #10

Open
zvezdochiot opened this issue Jul 4, 2022 · 2 comments
Open

Separate code and docs? #10

zvezdochiot opened this issue Jul 4, 2022 · 2 comments

Comments

@zvezdochiot
Copy link

Hi @MestreLion .

Subj. See also Sound-Linux-More@0233391
@zvezdochiot
Copy link
Author

Ignored.

@MestreLion
Copy link
Owner

Sorry for taking so long to reply!

What do you suggest, move all source files to /src? I'm fine with it, just make sure the root Makefile and related paths are all updated.

I don't have the time to properly test such a change, but I'd gladly merge a PR if you create one.

I've noticed Sound-Linux-More@0233391 does a lot more than just moving sources to /src: it also changes the compiler flag that forced a 32-bit executable, and I'm note sure this code works if 64 bits, see #2 . Did your 64-bit version worked fine with the test files in /test ? If so, feel free to send whatever you did to fix (as a separate PR) and I'll happily merge!

Once again, thanks for all your insights!

@MestreLion MestreLion reopened this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MestreLion @zvezdochiot