-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when attaching multiple images to MessageInputBar #16
Comments
Thanks @tkeithblack , want to make a PR? Sent with GitHawk |
I attempted to, but was unable to push the change to development.
Keith
…On Sun, Jan 6, 2019 at 9:36 PM Nathan Tannar ***@***.***> wrote:
Thanks @tkeithblack <https://github.com/tkeithblack> , want to make a PR?
Sent with GitHawk <http://githawk.com>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APlpe8K8iO05yR6CL2nHNbKwThgCU4VOks5vAsDFgaJpZM4Zys79>
.
|
@tkeithblack If you fork MK to your own repo you can make a PR from tahr branch. Sent with GitHawk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I encountered a crash when crash when inserting text followed by multiple pictures into the MessageInputBar.
The crash occurs in parseForComponents() located in InputTextView.swift.
The following line was the culprit:
let textRange = NSMakeRange(curLocation, range.location)
This worked fine on the first image, but subsequent images crashed because the length should be range.location-curLocation as below:
let textRange = NSMakeRange(curLocation, range.location-curLocation)
With this change it is now working.
KeithB
The text was updated successfully, but these errors were encountered: