Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template generation can fail due to a non-canonically ordered check on if the parents have been mentioned. #319

Open
kayabaNerve opened this issue Oct 1, 2021 · 0 comments
Open

Template generation can fail due to a non-canonically ordered check on if the parents have been mentioned. #319

kayabaNerve opened this issue Oct 1, 2021 · 0 comments
Labels
bug Something isn't working critical This needs to be fixed ASAP

Comments

@kayabaNerve
Copy link
Member

kayabaNerve commented Oct 1, 2021 •
edited
Loading

By a child checking if its parent has been mentioned, discovering its in that very Block, and then the template code checking the parent and realizing it has a missing parent, the parent will be removed yet the child will remain.

Unfortunately, this can not be effectively tested for due to the lack of ordering of sets/tables.
@kayabaNerve kayabaNerve added bug Something isn't working critical This needs to be fixed ASAP labels Oct 1, 2021
kayabaNerve added a commit that referenced this issue Oct 1, 2021
@kayabaNerve
Don't include TXs which would bring up old TXs in Block templates.
c806145 
Tests accordingly. Does tweak ConsensusObj getPending in the name of 
cleanliness. Reason #319 was 
found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working critical This needs to be fixed ASAP
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kayabaNerve