Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You should be able to claim funds to a Wallet that isn't on the local node. #313

Open
kayabaNerve opened this issue May 25, 2021 · 0 comments
Labels
feature New feature or request

Comments

@kayabaNerve
Copy link
Member

Currently, the funds are claimed to the local Wallet. You should be able to claim funds to an imported, watch only, wallet.

This does have two blockers.

  1. Current key derivation is where the BLS private key is the result of the BIP39 mnemonic's seed, and the Ristretto HD wallet uses the SHA256 hash of said seed. This would need to be flipped so the funded wallet cannot be recovered from the Merit Holder key. As we have no specific reason to keep it as is, yet do have this reason to flip it, I'm fine with this.

  2. The current wallet code doesn't optimally handle receiving funds to addresses it has yet to generate. It does, of course, handle this, yet the getUTXOs call doesn't check if the next unused address has been updated or not. A dummy call to getAddress in WalletDB's getUTXOs should be performed. This should be done regardless of this issue, to be honest.

Then the actual functionality (import a Watch Wallet WITH A Merit Holder private key) would need to be done.

@kayabaNerve kayabaNerve added the feature New feature or request label May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Development

No branches or pull requests

1 participant