-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The test at test-independent-fixed_design.R:141
is not stable
#451
Comments
test-independent-fixed_design.R:141
is not stable on macOStest-independent-fixed_design.R:141
is not stable
Apparently, I'm not the stats expert here but @elong0527 how about we set |
I like a explicit criteria as well. |
Thanks for pointing it out, @yihui ! I guess there are 2 issues leading to the instability of the testing:
|
Got it. Then it seems we need to either raise the tolerance (as I did in PR #455) or set a seed. I noticed that we were using a higher tolerance (0.01) for other tests: https://github.com/Merck/gsDesign2/blob/main/tests/testthat/test-independent-fixed_design.R so I wonder why this test was given a much smaller tolerance. |
gsDesign2/tests/testthat/test-independent-fixed_design.R
Line 141 in 32277b8
It throws an error sporadically, e.g.,
The tolerance was recently raised with e9317fd but may still not be enough.
The text was updated successfully, but these errors were encountered: