-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expander card not rendering iframe properly #351
Comments
Sorry but I don’t see a unexpected behavior. |
As you can see in the first picture compared to the one where it is embedded the roundshot is zoomed in. It is not possible to zoom out either with a mousewheel or scroll through the picture. Same with touch interactions. These little icons (the red camera for example in the first picture) serve as interaction points. These icons are all rendered in the upper left corner over each other when embedded within expander card. All these interactions work when not embedded within expander card and also in all versions before 2.3.0 Edit: Maybe this video illustrates the problem better recordbug.mp4 |
I see not directly a reason why it should work with the version before. With the listener there is no difference and did not change. |
I'm sorry, this I do not know either. However I can confirm it is working with 2.2.6 - I can record it as well if you want... |
How I said I see no reason why. PS: |
Sorry but your site is not working with or without expander. I tried your MRE and both are not working. Maybe try another iframe like
Works without issues |
That seems a bit odd. I mean I have it working in the video I uploaded...
It does look pretty similar to my code... |
That’s good because same listener and init card. For me it’s working on chrome browser and iPhone app. Also refresh the cache etc. works so far. |
But not with the frame url I posted...?
I noticed that when I try to edit the frame and it refreshes its content it behaves just like before. But only until I reload it. |
Basically every roundshot that is using https://www.roundshot.com/ is not working with your expander card. Could you maybe give me your config where it is working with these roundshots please? I verified it with Android, Windows (Edge as well as Chrome, could try Firefox), different devices as well. Also tested it on different homassistant instances and different roundshots. Always the same behaviour. After 2.3.0 it stops "listening". |
I never said that it works with roundshot. I just saying with my iframe see above e.g. windy etc. it's working. So sorry currently I have no time to test it. |
I think its a rendering issue with these roundshots.... not a listening issue. I suspect the roundshot rendering issue might be related to the changes introduced in fix #335. Specifically, it seems like the open and touchPreventClick variables were made reactive in the update, and this could be affecting the rendering behavior rather than the input listener logic. Could it be that the shift to reactive state handling is causing this issue? I wanted to bring this to your attention as a possible root cause. Let me know if you’d like more details or testing feedback! |
How I said: Test it I cannot say why this change should prevent zooming etc. this is just to prevent a click (expand/close) when you scroll. |
I created a fork where I reverted the changes from your #346 from your release 2.3.1. It seems to work. https://github.com/Caligo82/lovelace-expander-card/releases/tag/2.3.3 Is there maybe another way to fix this lag animation issue without impacting overall functionality? |
Since version 2.3.0 I have problems with an iframe embedded within an expander card. It sets the zoom level to maximum, makes the roundshot non scrollable and puts every icon on the top left corner.
standard iframe (working)
looks like this:
embedded iframe (not working)
looks like this:
The text was updated successfully, but these errors were encountered: