From 1e73424d631e8e9a3155079b38839102d269a866 Mon Sep 17 00:00:00 2001
From: tesar-tech <jan@tesar.tech>
Date: Mon, 16 Dec 2024 18:17:14 +0100
Subject: [PATCH 1/9] Breaking changes in examples leading from int -> long

---
 .../Pages/Tests/DataGrid/DataExternalSourcePage.razor          | 2 +-
 Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor   | 2 +-
 .../Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor.cs  | 2 +-
 Demos/Blazorise.Demo/Pages/Tests/DataGrid/PagerPage.razor      | 2 +-
 .../DataGrid/Examples/DataGridAggregatesLargeDataExample.razor | 2 +-
 .../DataGrid/Examples/DataGridLargeDataExample.razor           | 3 ++-
 .../Extensions/DataGrid/Examples/DataGridPagerExample.razor    | 2 +-
 7 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataExternalSourcePage.razor b/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataExternalSourcePage.razor
index 54b3298967..49a00e8357 100644
--- a/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataExternalSourcePage.razor
+++ b/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataExternalSourcePage.razor
@@ -101,7 +101,7 @@
 
         if ( !e.CancellationToken.IsCancellationRequested )
         {
-            IEnumerable<Employee> response = ( await GetDataFromExternalSource( e.Page, e.PageSize ) );
+            IEnumerable<Employee> response = ( await GetDataFromExternalSource( (int)e.Page, e.PageSize ) );
 
             if ( !e.CancellationToken.IsCancellationRequested )
             {
diff --git a/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor b/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor
index 6feea6e1d9..2499fb5b1a 100644
--- a/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor
+++ b/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor
@@ -256,7 +256,7 @@
                           CustomFilter="@OnCustomFilter"
                           PageSize="5"
                           CurrentPage="currentPage"
-                          PageChanged="(e) => currentPage = e.Page"
+                          PageChanged="(e) => currentPage = (int)e.Page"
                           FilteredDataChanged="@OnFilteredDataChanged"
                           UseValidation
                           SortChanged="@OnSortChanged"
diff --git a/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor.cs b/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor.cs
index a919ed91d4..f435e3ca11 100644
--- a/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor.cs
+++ b/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor.cs
@@ -211,7 +211,7 @@ private async Task OnReadData( DataGridReadDataEventArgs<Employee> e )
             if ( e.ReadDataMode is DataGridReadDataMode.Virtualize )
                 response = filteredData.Skip( e.VirtualizeOffset ).Take( e.VirtualizeCount ).ToList();
             else if ( e.ReadDataMode is DataGridReadDataMode.Paging )
-                response = filteredData.Skip( ( e.Page - 1 ) * e.PageSize ).Take( e.PageSize ).ToList();
+                response = filteredData.Skip( (int)( e.Page - 1 ) * e.PageSize ).Take( e.PageSize ).ToList();
             else
                 throw new Exception( "Unhandled ReadDataMode" );
 
diff --git a/Demos/Blazorise.Demo/Pages/Tests/DataGrid/PagerPage.razor b/Demos/Blazorise.Demo/Pages/Tests/DataGrid/PagerPage.razor
index 18b923499b..f958a187f9 100644
--- a/Demos/Blazorise.Demo/Pages/Tests/DataGrid/PagerPage.razor
+++ b/Demos/Blazorise.Demo/Pages/Tests/DataGrid/PagerPage.razor
@@ -51,7 +51,7 @@
                     <ItemsPerPageTemplate></ItemsPerPageTemplate>
                     <PageSelectorTemplate>
                         <Select TextColor="TextColor.Success" @bind-Value="@context.CurrentPage" Size="Size.Small">
-                            @for ( int i = context.FirstVisiblePage; i <= context.LastVisiblePage; ++i )
+                            @for ( long i = context.FirstVisiblePage; i <= context.LastVisiblePage; ++i )
                             {
                                 var pageNumber = i;
                                 <SelectItem Value="@pageNumber">@pageNumber</SelectItem>
diff --git a/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridAggregatesLargeDataExample.razor b/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridAggregatesLargeDataExample.razor
index 043d7a1924..4b16394f02 100644
--- a/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridAggregatesLargeDataExample.razor
+++ b/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridAggregatesLargeDataExample.razor
@@ -53,7 +53,7 @@
             if ( e.ReadDataMode is DataGridReadDataMode.Virtualize )
                 response = employeeList.Skip( e.VirtualizeOffset ).Take( e.VirtualizeCount ).ToList();
             else if ( e.ReadDataMode is DataGridReadDataMode.Paging )
-                response = employeeList.Skip( ( e.Page - 1 ) * e.PageSize ).Take( e.PageSize ).ToList();
+                response = employeeList.Skip( (int)( e.Page - 1 ) * e.PageSize ).Take( e.PageSize ).ToList();
             else
                 throw new Exception( "Unhandled ReadDataMode" );
 
diff --git a/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridLargeDataExample.razor b/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridLargeDataExample.razor
index 2d490c06d8..5227262bbd 100644
--- a/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridLargeDataExample.razor
+++ b/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridLargeDataExample.razor
@@ -58,7 +58,8 @@
             if ( e.ReadDataMode is DataGridReadDataMode.Virtualize )
                 response = ( await EmployeeData.GetDataAsync() ).Skip( e.VirtualizeOffset ).Take( e.VirtualizeCount ).ToList();
             else if ( e.ReadDataMode is DataGridReadDataMode.Paging )
-                response = ( await EmployeeData.GetDataAsync() ).Skip( ( e.Page - 1 ) * e.PageSize ).Take( e.PageSize ).ToList();
+                response = ( await EmployeeData.GetDataAsync() ).Skip((int)( e.Page - 1 ) * e.PageSize )//converting to int will break on collections larger than int.MaxValue
+                    .Take( e.PageSize ).ToList();
             else
                 throw new Exception( "Unhandled ReadDataMode" );
 
diff --git a/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridPagerExample.razor b/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridPagerExample.razor
index a3a707efa0..4d1c3f08ad 100644
--- a/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridPagerExample.razor
+++ b/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridPagerExample.razor
@@ -34,7 +34,7 @@
     <ItemsPerPageTemplate></ItemsPerPageTemplate>
     <PageSelectorTemplate>
         <Select TextColor="TextColor.Success" @bind-Value="@context.CurrentPage" Size="Size.Small">
-            @for ( int i = context.FirstVisiblePage; i <= context.LastVisiblePage; ++i )
+            @for ( long i = context.FirstVisiblePage; i <= context.LastVisiblePage; ++i )
             {
                 var pageNumber = i;
                 <SelectItem Value="@pageNumber">@pageNumber</SelectItem>

From a8427991b0d89d61da7c01b3ea5e0d1f6c882357 Mon Sep 17 00:00:00 2001
From: tesar-tech <jan@tesar.tech>
Date: Mon, 16 Dec 2024 18:23:36 +0100
Subject: [PATCH 2/9] int -> long in datagrid.TotalItems and related pieces.
 Safe-rails for virtualize

---
 .../Contexts/PageButtonContext.cs             |  6 ++--
 .../Contexts/PaginationContext.cs             | 28 +++++++++----------
 .../Blazorise.DataGrid/DataGrid.razor.cs      | 27 ++++++++++++------
 .../Blazorise.DataGrid/DataGridState.cs       |  2 +-
 .../DataGridFilteredDataEventArgs.cs          |  4 +--
 .../DataGridPageChangedEventArgs.cs           |  4 +--
 .../DataGridReadDataEventArgs.cs              |  4 +--
 .../_DataGridPagination.razor                 | 10 +++----
 8 files changed, 47 insertions(+), 38 deletions(-)

diff --git a/Source/Extensions/Blazorise.DataGrid/Contexts/PageButtonContext.cs b/Source/Extensions/Blazorise.DataGrid/Contexts/PageButtonContext.cs
index 6a440088a7..1d3b55cb2d 100644
--- a/Source/Extensions/Blazorise.DataGrid/Contexts/PageButtonContext.cs
+++ b/Source/Extensions/Blazorise.DataGrid/Contexts/PageButtonContext.cs
@@ -14,7 +14,7 @@ public class PageButtonContext
     /// </summary>
     /// <param name="pageNumber">Button page number .</param>
     /// <param name="active">Indicates if page is active.</param>
-    public PageButtonContext( int pageNumber, bool active )
+    public PageButtonContext( long pageNumber, bool active )
     {
         PageNumber = pageNumber;
         Active = active;
@@ -23,13 +23,13 @@ public PageButtonContext( int pageNumber, bool active )
     /// <summary>
     /// Gets the page number.
     /// </summary>
-    public int PageNumber { get; private set; }
+    public long PageNumber { get; private set; }
 
     /// <summary>
     /// Gets the page number.
     /// </summary>
     [Obsolete( "PageNumer is deprecated and will be removed in future versions, please use PageNumber instead.", true )]
-    public int PageNumer { get { return PageNumber; } set { PageNumber = value; } }
+    public long PageNumer { get { return PageNumber; } set { PageNumber = value; } }
 
     /// <summary>
     /// Get the flag that indicates if the page is active.
diff --git a/Source/Extensions/Blazorise.DataGrid/Contexts/PaginationContext.cs b/Source/Extensions/Blazorise.DataGrid/Contexts/PaginationContext.cs
index 0c9ec13ed0..fe5b774801 100644
--- a/Source/Extensions/Blazorise.DataGrid/Contexts/PaginationContext.cs
+++ b/Source/Extensions/Blazorise.DataGrid/Contexts/PaginationContext.cs
@@ -13,7 +13,7 @@ public class PaginationContext<TItem>
 
     private event CurrentPageChangedEventHandler CurrentPageChanged;
 
-    public delegate void CurrentPageChangedEventHandler( int value );
+    public delegate void CurrentPageChangedEventHandler( long value );
 
     private event CurrentPageSizeChangedEventHandler CurrentPageSizeChanged;
 
@@ -21,17 +21,17 @@ public class PaginationContext<TItem>
 
     private event TotalItemsChangedEventHandler TotalItemsChanged;
 
-    public delegate void TotalItemsChangedEventHandler( int value );
+    public delegate void TotalItemsChangedEventHandler( long value );
 
-    private int firstVisiblePage;
+    private long firstVisiblePage;
 
-    private int lastVisiblePage;
+    private long lastVisiblePage;
 
-    private int currentPage = 1;
+    private long currentPage = 1;
 
     private int currentPageSize = 10;
 
-    private int? totalItems;
+    private long? totalItems;
 
     private DataGrid<TItem> parentDataGrid;
 
@@ -58,7 +58,7 @@ public void UnsubscribeOnPageChanged( CurrentPageChangedEventHandler listener )
         CurrentPageChanged -= listener;
     }
 
-    public void TriggerCurrentPageChange( int value )
+    public void TriggerCurrentPageChange( long value )
     {
         CurrentPageChanged?.Invoke( value );
     }
@@ -88,7 +88,7 @@ public void UnsubscribeOnTotalItemsChanged( TotalItemsChangedEventHandler listen
         TotalItemsChanged -= listener;
     }
 
-    public void TriggerTotalItemsChange( int value )
+    public void TriggerTotalItemsChange( long value )
     {
         TotalItemsChanged?.Invoke( value );
     }
@@ -132,7 +132,7 @@ private void CalculateFirstAndLastVisiblePage()
     /// <summary>
     /// Gets or sets the current page
     /// </summary>
-    public int CurrentPage
+    public long CurrentPage
     {
         get => currentPage;
         set
@@ -148,11 +148,11 @@ public int CurrentPage
     /// <summary>
     /// Gets the last page number.
     /// </summary>
-    public int LastPage
+    public long LastPage
     {
         get
         {
-            var lastPage = Math.Max( (int)Math.Ceiling( ( TotalItems ?? 0 ) / (double)currentPageSize ), 1 );
+            long lastPage = Math.Max( (long)Math.Ceiling( ( TotalItems ?? 0 ) / (double)currentPageSize ), 1 );
 
             if ( CurrentPage > lastPage )
                 CurrentPage = lastPage;
@@ -164,7 +164,7 @@ public int LastPage
     /// <summary>
     /// Gets the number of the first page that can be clicked in a large dataset.
     /// </summary>
-    public int FirstVisiblePage
+    public long FirstVisiblePage
     {
         get
         {
@@ -177,7 +177,7 @@ public int FirstVisiblePage
     /// <summary>
     /// Gets the number of the last page that can be clicked in a large dataset.
     /// </summary>
-    public int LastVisiblePage
+    public long LastVisiblePage
     {
         get
         {
@@ -215,7 +215,7 @@ public int CurrentPageSize
     /// <remarks>
     /// This field must be set only when <see cref="DataGrid{TItem}.ReadData"/> is used to load the data.
     /// </remarks>
-    public int? TotalItems
+    public long? TotalItems
     {
         // If we're using ReadData than TotalItems must be set so we can know how many items are available
         get => ( ( parentDataGrid.ManualReadMode || parentDataGrid.VirtualizeManualReadMode ) ? totalItems : parentDataGrid.FilteredData?.Count() ) ?? 0;
diff --git a/Source/Extensions/Blazorise.DataGrid/DataGrid.razor.cs b/Source/Extensions/Blazorise.DataGrid/DataGrid.razor.cs
index b34ddec160..d74ab0b7b2 100644
--- a/Source/Extensions/Blazorise.DataGrid/DataGrid.razor.cs
+++ b/Source/Extensions/Blazorise.DataGrid/DataGrid.razor.cs
@@ -1026,7 +1026,7 @@ private async void OnPageSizeChanged( int pageSize )
         await ReloadInternal( paginationContext.CancellationTokenSource.Token );
     }
 
-    private async void OnPageChanged( int currentPage )
+    private async void OnPageChanged( long currentPage )
     {
         paginationContext.CancellationTokenSource?.Cancel();
         paginationContext.CancellationTokenSource = new();
@@ -2172,14 +2172,22 @@ protected async ValueTask<ItemsProviderResult<TItem>> VirtualizeItemsProviderHan
             ? Math.Min( request.Count, TotalItems.Value - request.StartIndex )
             : request.Count;
 
-        await HandleVirtualizeReadData( request.StartIndex, requestCount, request.CancellationToken );
+        await HandleVirtualizeReadData( request.StartIndex, (int)requestCount, request.CancellationToken );
         await Task.Yield(); // This line makes sure SetParametersAsync catches up, since we depend upon Data Parameter.
 
         if ( request.CancellationToken.IsCancellationRequested )
             return default;
         else
-            return new( Data.ToList(), TotalItems.Value );
+            return new( Data.ToList(), LongToIntSafe(TotalItems) );//safty rails for virualize - doesn't overflow, but doesn't work either
     }
+    
+    int LongToIntSafe(long? value) => value switch
+    {
+        null => 0,
+        > int.MaxValue => int.MaxValue,
+        < int.MinValue => int.MinValue,
+        _ => (int)value
+    };
 
     internal async Task HandleSelectedCell( TItem item, DataGridRowInfo<TItem> rowInfo, DataGridColumn<TItem> column )
     {
@@ -2730,14 +2738,15 @@ private IEnumerable<TItem> FilterViewData()
         // only use pagination if the custom data loading is not used
         if ( !ManualReadMode && !Virtualize )
         {
-            var skipElements = ( CurrentPage - 1 ) * PageSize;
+            long skipElements = ( CurrentPage - 1 ) * PageSize;
             if ( skipElements > filteredData.Count )
             {
                 CurrentPage = paginationContext.LastPage;
                 skipElements = ( CurrentPage - 1 ) * PageSize;
             }
-
-            return filteredData.Skip( skipElements ).Take( PageSize );
+            
+            //here the conversion to int is safe, because without manualReadMode it's not probable user will use more than int.MaxValue data  
+            return filteredData.Skip( (int)skipElements ).Take( PageSize );
         }
 
         return filteredData;
@@ -3208,7 +3217,7 @@ private bool IsMultiSelectAllIndeterminate
     /// <remarks>
     /// This field must be set only when <see cref="ReadData"/> is used to load the data.
     /// </remarks>
-    [Parameter] public int? TotalItems { get => paginationContext.TotalItems; set => paginationContext.TotalItems = value; }
+    [Parameter] public long? TotalItems { get => paginationContext.TotalItems; set => paginationContext.TotalItems = value; }
 
     /// <summary>
     /// Gets the data after all of the filters have being applied.
@@ -3377,7 +3386,7 @@ public IReadOnlyList<DataGridBatchEditItem<TItem>> BatchChanges
     /// <summary>
     /// Gets or sets the current page number.
     /// </summary>
-    [Parameter] public int CurrentPage { get => paginationContext.CurrentPage; set => paginationContext.CurrentPage = value; }
+    [Parameter] public long CurrentPage { get => paginationContext.CurrentPage; set => paginationContext.CurrentPage = value; }
 
     protected PaginationContext<TItem> PaginationContext => paginationContext;
 
@@ -3850,7 +3859,7 @@ public IReadOnlyList<DataGridBatchEditItem<TItem>> BatchChanges
     /// <summary>
     /// Gets a zero-based index of the currently selected row if found; otherwise it'll return -1. Considers the current pagination.
     /// </summary>
-    public int SelectedRowIndex
+    public long SelectedRowIndex
     {
         get
         {
diff --git a/Source/Extensions/Blazorise.DataGrid/DataGridState.cs b/Source/Extensions/Blazorise.DataGrid/DataGridState.cs
index 49d312571d..fa6c2dee38 100644
--- a/Source/Extensions/Blazorise.DataGrid/DataGridState.cs
+++ b/Source/Extensions/Blazorise.DataGrid/DataGridState.cs
@@ -120,7 +120,7 @@ private static string ExtractFieldName<TValue>( Expression<Func<TItem, TValue>>
     /// <summary>
     /// Gets or sets the current page number.
     /// </summary>
-    public int CurrentPage { get; set; }
+    public long CurrentPage { get; set; }
 
     /// <summary>
     /// Gets or sets the maximum number of items for each page.
diff --git a/Source/Extensions/Blazorise.DataGrid/EventArguments/DataGridFilteredDataEventArgs.cs b/Source/Extensions/Blazorise.DataGrid/EventArguments/DataGridFilteredDataEventArgs.cs
index acf8c7c55e..3f03d5fa1e 100644
--- a/Source/Extensions/Blazorise.DataGrid/EventArguments/DataGridFilteredDataEventArgs.cs
+++ b/Source/Extensions/Blazorise.DataGrid/EventArguments/DataGridFilteredDataEventArgs.cs
@@ -17,7 +17,7 @@ public class DataGridFilteredDataEventArgs<TItem> : EventArgs
     /// <param name="filteredData">List of filtered data items.</param>
     /// <param name="filteredItems">Number of filtered items.</param>
     /// <param name="totalItems">Total available items in the data-source.</param>
-    public DataGridFilteredDataEventArgs( IEnumerable<TItem> filteredData, int filteredItems, int totalItems )
+    public DataGridFilteredDataEventArgs( IEnumerable<TItem> filteredData, int filteredItems, long totalItems )
     {
         Data = filteredData;
         FilteredItems = filteredItems;
@@ -37,5 +37,5 @@ public DataGridFilteredDataEventArgs( IEnumerable<TItem> filteredData, int filte
     /// <summary>
     /// Gets the total available items in the data-source.
     /// </summary>
-    public int TotalItems { get; }
+    public long TotalItems { get; }
 }
\ No newline at end of file
diff --git a/Source/Extensions/Blazorise.DataGrid/EventArguments/DataGridPageChangedEventArgs.cs b/Source/Extensions/Blazorise.DataGrid/EventArguments/DataGridPageChangedEventArgs.cs
index f8f6c8cd15..2845a00cb0 100644
--- a/Source/Extensions/Blazorise.DataGrid/EventArguments/DataGridPageChangedEventArgs.cs
+++ b/Source/Extensions/Blazorise.DataGrid/EventArguments/DataGridPageChangedEventArgs.cs
@@ -14,7 +14,7 @@ public class DataGridPageChangedEventArgs : EventArgs
     /// </summary>
     /// <param name="page">Page number at the moment of initialization.</param>
     /// <param name="pageSize">Maximum number of items per page.</param>
-    public DataGridPageChangedEventArgs( int page, int pageSize )
+    public DataGridPageChangedEventArgs( long page, int pageSize )
     {
         Page = page;
         PageSize = pageSize;
@@ -23,7 +23,7 @@ public DataGridPageChangedEventArgs( int page, int pageSize )
     /// <summary>
     /// Gets the requested page number.
     /// </summary>
-    public int Page { get; }
+    public long Page { get; }
 
     /// <summary>
     /// Gets the max number of items requested by page.
diff --git a/Source/Extensions/Blazorise.DataGrid/EventArguments/DataGridReadDataEventArgs.cs b/Source/Extensions/Blazorise.DataGrid/EventArguments/DataGridReadDataEventArgs.cs
index 038c62dd14..ff0e581b5e 100644
--- a/Source/Extensions/Blazorise.DataGrid/EventArguments/DataGridReadDataEventArgs.cs
+++ b/Source/Extensions/Blazorise.DataGrid/EventArguments/DataGridReadDataEventArgs.cs
@@ -44,7 +44,7 @@ public DataGridReadDataEventArgs(
         DataGridReadDataMode readDataMode,
         IEnumerable<DataGridColumn<TItem>> columns,
         IList<DataGridColumn<TItem>> sortByColumns,
-        int page,
+        long page,
         int pageSize,
         int virtualizeOffset,
         int virtualizeCount,
@@ -77,7 +77,7 @@ public DataGridReadDataEventArgs(
     /// <summary>
     /// Gets the requested page number.
     /// </summary>
-    public int Page { get; }
+    public long Page { get; }
 
     /// <summary>
     /// Gets the max number of items requested by page.
diff --git a/Source/Extensions/Blazorise.DataGrid/_DataGridPagination.razor b/Source/Extensions/Blazorise.DataGrid/_DataGridPagination.razor
index db3f697e37..cdf4efa53d 100644
--- a/Source/Extensions/Blazorise.DataGrid/_DataGridPagination.razor
+++ b/Source/Extensions/Blazorise.DataGrid/_DataGridPagination.razor
@@ -153,7 +153,7 @@
                 }
                 else
                 {
-                    var totalItems = PaginationContext?.TotalItems ?? default;
+                    long totalItems = PaginationContext?.TotalItems ?? default;
 
                     if ( totalItems == 0 )
                     {
@@ -161,8 +161,8 @@
                     }
                     else
                     {
-                        var curStart = ( ( PaginationContext.CurrentPage - 1 ) * PaginationContext.CurrentPageSize + 1 );
-                        var curEnd = Math.Min( PaginationContext.CurrentPage * PaginationContext.CurrentPageSize, totalItems );
+                        long curStart = ( ( PaginationContext.CurrentPage - 1 ) * PaginationContext.CurrentPageSize + 1 );
+                        long curEnd = Math.Min( PaginationContext.CurrentPage * PaginationContext.CurrentPageSize, totalItems );
                         <Text>@Localizer.Localize( ParentDataGrid.Localizers?.NumbersOfItemsLocalizer, "{0} - {1} of {2} items", curStart, curEnd, totalItems )</Text>
                     }
                 }
@@ -210,7 +210,7 @@
                         }
                     </PaginationLink>
                 </PaginationItem>
-                @for ( int i = PaginationContext.FirstVisiblePage; i <= PaginationContext.LastVisiblePage; ++i )
+                @for ( long i = PaginationContext.FirstVisiblePage; i <= PaginationContext.LastVisiblePage; ++i )
                 {
                     var pageNumber = i;
                     var pageNumberString = i.ToString();
@@ -237,7 +237,7 @@
                     else
                     {
                         <Select @bind-Value="@PaginationContext.CurrentPage" Size="GetSize()">
-                            @for ( int i = PaginationContext.FirstVisiblePage; i <= PaginationContext.LastVisiblePage; ++i )
+                            @for ( long i = PaginationContext.FirstVisiblePage; i <= PaginationContext.LastVisiblePage; ++i )
                             {
                                 var pageNumber = i;
                                 <SelectItem Value="@pageNumber">@pageNumber</SelectItem>

From a99608aab3c0fea5be7490fe4d26ce27c937c8cd Mon Sep 17 00:00:00 2001
From: tesar-tech <jan@tesar.tech>
Date: Mon, 16 Dec 2024 18:24:12 +0100
Subject: [PATCH 3/9] DataGridLargePage.razor showcase of int.MaxValue+
 datasets support.

---
 .../Tests/DataGrid/DataGridLargePage.razor    | 62 +++++++++++++++++++
 1 file changed, 62 insertions(+)
 create mode 100644 Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridLargePage.razor

diff --git a/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridLargePage.razor b/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridLargePage.razor
new file mode 100644
index 0000000000..b4778823cf
--- /dev/null
+++ b/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridLargePage.razor
@@ -0,0 +1,62 @@
+@page "/tests/datagridlarge"
+
+<h3>DataGrid on datasets larger than int.MaxValue</h3>
+
+<DataGrid TItem="LargeModelItem"
+          Data="items"
+          TotalItems="totalCount"
+          ReadData="OnDataRead"
+          ShowPager
+>
+    <DataGridColumn Field="@nameof( LargeModelItem.Id )" Caption="id" />
+    <DataGridColumn Field="@nameof( LargeModelItem.Name )" Caption="Name" Editable/>
+</DataGrid>
+
+
+
+@code {
+    class LargeModelItem
+    {
+        public long Id { get; set; }
+        public string Name { get; set; } = "";
+    }
+
+
+    long totalCount = 10_000_000_000_000;//
+    
+    IEnumerable<LargeModelItem> items = Enumerable.Empty<LargeModelItem>();
+    
+    private void OnDataRead(DataGridReadDataEventArgs<LargeModelItem> e)
+    {
+
+        // if (e.ReadDataMode == DataGridReadDataMode.Virtualize)
+        // {
+        //     
+        // items = Enumerable.Range(e.VirtualizeOffset, e.VirtualizeCount).Select(i => new LargeModelItem
+        // {
+        //     Id = i,
+        //     Name = $"Item id { i} "
+        // });
+        // }
+        
+        if (e.ReadDataMode == DataGridReadDataMode.Paging)
+        {
+            items = LongRange((e.Page - 1) * e.PageSize, e.PageSize)
+                .Select(i => new LargeModelItem
+                {
+                    Id = i,
+                    Name = $"Item id {i}"
+                });
+        }
+
+    }
+
+
+    public static IEnumerable<long> LongRange(long start, long count)
+    {
+        for (long i = 0; i < count; i++)
+        {
+            yield return start + i;
+        }
+    }
+}
\ No newline at end of file

From e6096120a73d79d6cc611c583111fa2bcdee38bd Mon Sep 17 00:00:00 2001
From: tesar-tech <jan@tesar.tech>
Date: Tue, 17 Dec 2024 17:48:34 +0100
Subject: [PATCH 4/9] Virtualization limits

---
 .../Extensions/DataGrid/BindingData/VirtualizePage.razor  | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/BindingData/VirtualizePage.razor b/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/BindingData/VirtualizePage.razor
index bb8f25ebb3..2332f15b71 100644
--- a/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/BindingData/VirtualizePage.razor
+++ b/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/BindingData/VirtualizePage.razor
@@ -30,6 +30,14 @@
                 <Blazorise.Link To="https://github.com/dotnet/aspnetcore/issues/28280">TaskCanceledException when scrolling Virtualized component #28280</Blazorise.Link>
             </AlertDescription>
         </Alert>
+
+        <Alert Margin="Margin.Is4.FromTop" Color="Color.Info" Visible>
+            <AlertDescription>
+                Virtualization does not support large datasets (approximately 1 million or more items, depending on the height of the items). This is a known browser technical limitation.
+                <Blazorise.Link To="https://github.com/dotnet/aspnetcore/issues/26354">See more</Blazorise.Link>
+                For scenarios involving very large datasets, we strongly recommend using a pagination approach instead.
+            </AlertDescription>
+        </Alert>
     </DocsPageSectionHeader>
     <DocsPageSectionContent FullWidth>
         <DataGridVirtualizeExample />

From 9d4c78c5d830b39a029cf781337d80270b6e411f Mon Sep 17 00:00:00 2001
From: tesar-tech <jan@tesar.tech>
Date: Tue, 17 Dec 2024 17:59:01 +0100
Subject: [PATCH 5/9] Comments on casts to int

---
 Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor  | 2 +-
 .../Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor.cs | 4 ++--
 .../Examples/DataGridAggregatesLargeDataExample.razor         | 2 +-
 .../DataGrid/Examples/DataGridLargeDataExample.razor          | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor b/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor
index 2499fb5b1a..6feea6e1d9 100644
--- a/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor
+++ b/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor
@@ -256,7 +256,7 @@
                           CustomFilter="@OnCustomFilter"
                           PageSize="5"
                           CurrentPage="currentPage"
-                          PageChanged="(e) => currentPage = (int)e.Page"
+                          PageChanged="(e) => currentPage = e.Page"
                           FilteredDataChanged="@OnFilteredDataChanged"
                           UseValidation
                           SortChanged="@OnSortChanged"
diff --git a/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor.cs b/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor.cs
index f435e3ca11..a195053c2e 100644
--- a/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor.cs
+++ b/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor.cs
@@ -27,7 +27,7 @@ public partial class DataGridPage
     private TableResponsiveMode responsiveMode = TableResponsiveMode.Default;
 
     private DataGrid<Employee> dataGrid;
-    public int currentPage { get; set; } = 1;
+    public long currentPage { get; set; } = 1;
 
     private bool editable = true;
     private bool fixedHeader = false;
@@ -211,7 +211,7 @@ private async Task OnReadData( DataGridReadDataEventArgs<Employee> e )
             if ( e.ReadDataMode is DataGridReadDataMode.Virtualize )
                 response = filteredData.Skip( e.VirtualizeOffset ).Take( e.VirtualizeCount ).ToList();
             else if ( e.ReadDataMode is DataGridReadDataMode.Paging )
-                response = filteredData.Skip( (int)( e.Page - 1 ) * e.PageSize ).Take( e.PageSize ).ToList();
+                response = filteredData.Skip( (int)( e.Page - 1 ) * e.PageSize ).Take( e.PageSize ).ToList();// Converting to `int` is necessary for the `Skip()` method. However, it will still break on datasets larger than `int.MaxValue` items. Be mindful of the size of your data.
             else
                 throw new Exception( "Unhandled ReadDataMode" );
 
diff --git a/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridAggregatesLargeDataExample.razor b/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridAggregatesLargeDataExample.razor
index 4b16394f02..16517d6ffa 100644
--- a/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridAggregatesLargeDataExample.razor
+++ b/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridAggregatesLargeDataExample.razor
@@ -53,7 +53,7 @@
             if ( e.ReadDataMode is DataGridReadDataMode.Virtualize )
                 response = employeeList.Skip( e.VirtualizeOffset ).Take( e.VirtualizeCount ).ToList();
             else if ( e.ReadDataMode is DataGridReadDataMode.Paging )
-                response = employeeList.Skip( (int)( e.Page - 1 ) * e.PageSize ).Take( e.PageSize ).ToList();
+                response = employeeList.Skip( (int)( e.Page - 1 ) * e.PageSize ).Take( e.PageSize ).ToList();// Converting to `int` is necessary for the `Skip()` method. However, it will still break on datasets larger than `int.MaxValue` items. Be mindful of the size of your data.
             else
                 throw new Exception( "Unhandled ReadDataMode" );
 
diff --git a/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridLargeDataExample.razor b/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridLargeDataExample.razor
index 5227262bbd..27ba660df6 100644
--- a/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridLargeDataExample.razor
+++ b/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridLargeDataExample.razor
@@ -58,7 +58,7 @@
             if ( e.ReadDataMode is DataGridReadDataMode.Virtualize )
                 response = ( await EmployeeData.GetDataAsync() ).Skip( e.VirtualizeOffset ).Take( e.VirtualizeCount ).ToList();
             else if ( e.ReadDataMode is DataGridReadDataMode.Paging )
-                response = ( await EmployeeData.GetDataAsync() ).Skip((int)( e.Page - 1 ) * e.PageSize )//converting to int will break on collections larger than int.MaxValue
+                response = ( await EmployeeData.GetDataAsync() ).Skip((int)( e.Page - 1 ) * e.PageSize )// Converting to `int` is necessary for the `Skip()` method. However, it will still break on datasets larger than `int.MaxValue` items. Be mindful of the size of your data.
                     .Take( e.PageSize ).ToList();
             else
                 throw new Exception( "Unhandled ReadDataMode" );

From ca63d12fc6c9cd5a4fcef79129eb6421c3072115 Mon Sep 17 00:00:00 2001
From: tesar-tech <jan@tesar.tech>
Date: Tue, 17 Dec 2024 18:28:39 +0100
Subject: [PATCH 6/9] Update release notes

---
 .../News/2025-05-01-release-notes-200.razor   | 33 +++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/Documentation/Blazorise.Docs/Pages/News/2025-05-01-release-notes-200.razor b/Documentation/Blazorise.Docs/Pages/News/2025-05-01-release-notes-200.razor
index 7d601f2206..1310403c13 100644
--- a/Documentation/Blazorise.Docs/Pages/News/2025-05-01-release-notes-200.razor
+++ b/Documentation/Blazorise.Docs/Pages/News/2025-05-01-release-notes-200.razor
@@ -26,6 +26,12 @@
             <Strong>DataGridSelectColumn</Strong>: Multiple support
         </Paragraph>
     </UnorderedListItem>
+
+    <UnorderedListItem>
+        <Paragraph>
+            <Strong>DataGrid</Strong>: Support for datasets larger than <Code>int.MaxValue</Code> items
+        </Paragraph>
+    </UnorderedListItem>
 </UnorderedList>
 
 <Paragraph>
@@ -88,6 +94,33 @@
                 </UnorderedListItem>
             </UnorderedList>
         </OrderedListItem>
+
+        <OrderedListItem>
+            <Paragraph>
+                DataGrid TotalItems is now long instead of int. Here is the list of all properties that have been changed to <Code>long</Code>
+            </Paragraph>
+            <UnorderedList>
+                    <UnorderedListItem>
+                        <Strong>DataGrid:</Strong> <Code>TotalItems</Code>, <Code>CurrentPage</Code>  (renamed to <Code>Page</Code> in 2.0), <Code>SelectedRowIndex</Code>
+                    </UnorderedListItem>
+
+                    <UnorderedListItem>
+                        <Strong>PaginationContext:</Strong> <Code>CurrentPage</Code>, <Code>LastPage</Code>, <Code>FirstVisiblePage</Code>, <Code>LastVisiblePage</Code>, <Code>TotalItems</Code>
+                    </UnorderedListItem>
+
+                    <UnorderedListItem>
+                        <Strong>PageButtonContext:</Strong> <Code>PageNumber</Code>
+                    </UnorderedListItem>
+
+                    <UnorderedListItem>
+                        <Strong>DataGridFilteredDataEventArgs:</Strong> <Code>TotalItems</Code>
+                    </UnorderedListItem>
+
+                    <UnorderedListItem>
+                        <Strong>DataGridReadDataEventArguments:</Strong> <Code>Page</Code>
+                    </UnorderedListItem>
+            </UnorderedList>
+        </OrderedListItem>
     </OrderedList>
 </Paragraph>
 

From 5d06ced44704b03e862549e4d4c9ddfbdd56293b Mon Sep 17 00:00:00 2001
From: tesar-tech <jan@tesar.tech>
Date: Mon, 23 Dec 2024 11:36:06 +0100
Subject: [PATCH 7/9] back to long in PageChanged

---
 Source/Extensions/Blazorise.DataGrid/DataGrid.razor.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Source/Extensions/Blazorise.DataGrid/DataGrid.razor.cs b/Source/Extensions/Blazorise.DataGrid/DataGrid.razor.cs
index ebd62c1293..6f994d9609 100644
--- a/Source/Extensions/Blazorise.DataGrid/DataGrid.razor.cs
+++ b/Source/Extensions/Blazorise.DataGrid/DataGrid.razor.cs
@@ -3408,7 +3408,7 @@ public IReadOnlyList<DataGridBatchEditItem<TItem>> BatchChanges
     /// <summary>
     /// Occurs after the selected page has changed.
     /// </summary>
-    [Parameter] public EventCallback<int> PageChanged { get; set; }
+    [Parameter] public EventCallback<long> PageChanged { get; set; }
 
     /// <summary>
     /// Gets or sets content of table body for empty DisplayData.

From ba48e504f8de4d1fa5d4a260cfd7d89d72c51257 Mon Sep 17 00:00:00 2001
From: tesar-tech <jan@tesar.tech>
Date: Mon, 23 Dec 2024 12:10:31 +0100
Subject: [PATCH 8/9] ExpressionCompiler.cs "fix" and comment on larger
 datasets

---
 .../DataGridLargeDataExpressionCompilerExample.razor        | 2 +-
 .../Blazorise.DataGrid/Utils/ExpressionCompiler.cs          | 6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridLargeDataExpressionCompilerExample.razor b/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridLargeDataExpressionCompilerExample.razor
index f76a7c0ea0..0d4ff59c57 100644
--- a/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridLargeDataExpressionCompilerExample.razor
+++ b/Documentation/Blazorise.Docs/Pages/Docs/Extensions/DataGrid/Examples/DataGridLargeDataExpressionCompilerExample.razor
@@ -49,7 +49,7 @@
             if (e.ReadDataMode is DataGridReadDataMode.Virtualize)
                 response = query.ApplyDataGridPaging(e.VirtualizeOffset + 1, e.VirtualizeCount).ToList();
             else if (e.ReadDataMode is DataGridReadDataMode.Paging)
-                response = query.ApplyDataGridPaging(e.Page, e.PageSize).ToList();
+                response = query.ApplyDataGridPaging((int)e.Page, e.PageSize).ToList();
             else
                 throw new Exception("Unhandled ReadDataMode");
 
diff --git a/Source/Extensions/Blazorise.DataGrid/Utils/ExpressionCompiler.cs b/Source/Extensions/Blazorise.DataGrid/Utils/ExpressionCompiler.cs
index b452bc321b..476a798092 100644
--- a/Source/Extensions/Blazorise.DataGrid/Utils/ExpressionCompiler.cs
+++ b/Source/Extensions/Blazorise.DataGrid/Utils/ExpressionCompiler.cs
@@ -309,6 +309,8 @@ public static IQueryable<TItem> ApplyDataGridSort<TItem>( this IQueryable<TItem>
 
     /// <summary>
     /// Applies the paging filter to the queryable data.
+    /// Only usable for datasets of approximately 1 million items when using virtualization.  
+    /// Only usable for datasets up to `int.MaxValue` items when using paging.
     /// </summary>
     /// <typeparam name="TItem"></typeparam>
     /// <param name="data">The Data to be queried</param>
@@ -363,6 +365,8 @@ public static IQueryable<TItem> ApplyDataGridSort<TItem>( this IQueryable<TItem>
 
     /// <summary>
     /// Applies the paging filter to the queryable data.
+    /// Only usable for datasets of approximately 1 million items when using virtualization.  
+    /// Only usable for datasets up to `int.MaxValue` items when using paging.
     /// </summary>
     /// <typeparam name="TItem"></typeparam>
     /// <param name="data">The Data to be queried</param>
@@ -373,7 +377,7 @@ public static IQueryable<TItem> ApplyDataGridPaging<TItem>( this IQueryable<TIte
         if ( dataGridReadDataEventArgs.ReadDataMode is DataGridReadDataMode.Virtualize )
             data = data.ApplyDataGridPaging( dataGridReadDataEventArgs.VirtualizeOffset + 1, dataGridReadDataEventArgs.VirtualizeCount );
         else if ( dataGridReadDataEventArgs.ReadDataMode is DataGridReadDataMode.Paging )
-            data = data.ApplyDataGridPaging( dataGridReadDataEventArgs.Page, dataGridReadDataEventArgs.PageSize );
+            data = data.ApplyDataGridPaging( (int)dataGridReadDataEventArgs.Page, dataGridReadDataEventArgs.PageSize );
 
         return data;
     }

From 01f53c99ef4fe538dd7e1b4a92704b014c97ffb9 Mon Sep 17 00:00:00 2001
From: tesar-tech <jan@tesar.tech>
Date: Mon, 23 Dec 2024 12:22:10 +0100
Subject: [PATCH 9/9] pagesize back to int (mistake on merging)

---
 Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor.cs b/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor.cs
index a20bb61d7a..b18db25669 100644
--- a/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor.cs
+++ b/Demos/Blazorise.Demo/Pages/Tests/DataGrid/DataGridPage.razor.cs
@@ -28,7 +28,7 @@ public partial class DataGridPage
 
     private DataGrid<Employee> dataGrid;
     public long currentPage { get; set; } = 1;
-    public long currentPageSize  { get; set; } = 5; 
+    public int currentPageSize  { get; set; } = 5; 
 
     private bool editable = true;
     private bool fixedHeader = false;