Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataGridCheckColumn does not use Theme.ColorOptions.Primary #4932

Open
oaldrian opened this issue Aug 16, 2023 · 7 comments
Open

DataGridCheckColumn does not use Theme.ColorOptions.Primary #4932

oaldrian opened this issue Aug 16, 2023 · 7 comments
Assignees
Labels
Area: Documentation Something is missing in the documentation.
Milestone

Comments

@oaldrian
Copy link
Contributor

Describe the bug
According to @stsrki DataGridCheckColumn should use Theme.ColorOptions.Primary as base of its color.
This does not work.

To Reproduce
see reproduction in https://github.com/oaldrian/BlazoriseReproductions/tree/datagrid-checkcolumn-color
Index.razor and App.razor

Expected behavior
DataGridCheckColumn should use Theme.ColorOptions.Primary as base of its color.

Screenshots
Screenshot 2023-08-16 191000

Additional context
Tested on 1.3

@oaldrian oaldrian added the Type: Bug 🐞 Something isn't working label Aug 16, 2023
@oaldrian
Copy link
Contributor Author

seems to also happen for the normal check component, when there is no specific color set.

@stsrki
Copy link
Collaborator

stsrki commented Aug 17, 2023

I might inform you wrong in the Discord channel.

Can you try this?

image

@oaldrian
Copy link
Contributor Author

could be closed as InputOption does solve the problem.

But I would suggest to do an overhaul of the theming section of the docs, to actually include all needed options.

@stsrki stsrki self-assigned this Aug 30, 2023
@stsrki stsrki added this to the 1.3 support milestone Aug 30, 2023
@stsrki stsrki added Area: Documentation Something is missing in the documentation. and removed Type: Bug 🐞 Something isn't working Status: Expecting Answer labels Aug 30, 2023
@stsrki stsrki assigned steal4life and unassigned stsrki Oct 14, 2023
@stsrki
Copy link
Collaborator

stsrki commented Oct 14, 2023

@steal4life We need to create new API page for the theming options where all the fields will be mentioned.

@stsrki stsrki modified the milestones: 1.3 support, 1.4 support Mar 19, 2024
@stsrki stsrki added this to Support Aug 3, 2024
@stsrki stsrki moved this to 🔙 Backlog in Support Aug 3, 2024
@stsrki stsrki modified the milestones: 1.4 support, 1.6 support Oct 24, 2024
@stsrki stsrki assigned tesar-tech and unassigned steal4life Jan 16, 2025
@stsrki stsrki modified the milestones: 1.6 support, 1.7 support Jan 16, 2025
@tesar-tech
Copy link
Collaborator

Just to clarify—are we aiming to bring all the classes from the Themes folder to api docs (as we have it for components)

This will require a few updates, but it doesn't seem too complicated.

Also, is there any other part of the Blazorise source code that we should consider including in the api docs? If so, I can work on creating a more general solution for it, saving time for the future.

@stsrki
Copy link
Collaborator

stsrki commented Jan 24, 2025

Just to clarify—are we aiming to bring all the classes from the Themes folder to api docs (as we have it for components)

This will require a few updates, but it doesn't seem too complicated.

Also, is there any other part of the Blazorise source code that we should consider including in the api docs? If so, I can work on creating a more general solution for it, saving time for the future.

It wouldn't hurt to have them all listed.

I can think of Chart options. Did we have some problem with those?

@tesar-tech
Copy link
Collaborator

Did we have some problem with those?

I think we just didn't complete those.

I will look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Documentation Something is missing in the documentation.
Projects
Status: 🔙 Backlog
Development

No branches or pull requests

5 participants