You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the indices to get grains out of hrdic.Map are off by one relative to the integer IDs in the hrdic.Map.grains image. That is, hrdic.Map[0] gets the grain that has value 1 in the image, hrdic.Map[1] gets the grain with value 2, and so on. (And this might be incorrect if the grains array has non-contiguous labels, not sure.) This is confusing! I understand that this is perhaps inherited from or inspired by skimage.measure.regionprops, but over there we regret that API choice and will probably move to a dictionary-like API with the label as the key in a later version.
Would there be interest in taking the same approach here?
The text was updated successfully, but these errors were encountered:
Currently, the indices to get grains out of
hrdic.Map
are off by one relative to the integer IDs in thehrdic.Map.grains
image. That is,hrdic.Map[0]
gets the grain that has value 1 in the image,hrdic.Map[1]
gets the grain with value 2, and so on. (And this might be incorrect if thegrains
array has non-contiguous labels, not sure.) This is confusing! I understand that this is perhaps inherited from or inspired byskimage.measure.regionprops
, but over there we regret that API choice and will probably move to a dictionary-like API with the label as the key in a later version.Would there be interest in taking the same approach here?
The text was updated successfully, but these errors were encountered: