Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the UX of searching for a URL #1195

Open
KaKi87 opened this issue Oct 20, 2024 · 9 comments
Open

Improve the UX of searching for a URL #1195

KaKi87 opened this issue Oct 20, 2024 · 9 comments
Labels
backend Backend related issues and pull requests enhancement New feature or request good first issue Good for newcomers

Comments

@KaKi87
Copy link

KaKi87 commented Oct 20, 2024

Is your feature request related to a problem? Please describe.
Remote posts can be unavailable locally.

Describe the solution you'd like
Fetch posts when searched by URL.

Describe alternatives you've considered
None

Additional context
Cf. Kbin/[email protected]#497


Thanks

@KaKi87 KaKi87 added the enhancement New feature or request label Oct 20, 2024
@BentiGorlich
Copy link
Member

Hi there, this is already implemented. With some lemmy instances it just won't work because they don't let anyone fetch the data if it was not sent to them, but generally it works just fine.
However the process is a bit in-transparent. When you search for a url the server will look in the db if we already know of a post with that url. If that is not the case, then the server will put a job in the queue to fetch the post on that url. That is done in the background. So your search result will look empty, when the server is actually getting the post. If you refresh the page ~5 minutes later, the post will be there...

I get that this is not a good UX, so if you want you can rephrase this issue to improve the UX of searching for a URL

@KaKi87
Copy link
Author

KaKi87 commented Nov 4, 2024

this is already implemented

Oh, nice, then I'd like to suggest adding that to the list of unique features in the README (or did I miss the related PR ?).

your search result will look empty, when the server is actually getting the post. If you refresh the page ~5 minutes later, the post will be there...

I get that this is not a good UX

Yeah, it would be nice to have the usual Fediverse experience, i.e. fetch and return at search.

rephrase this issue to improve the UX of searching for a URL

Will do.

@KaKi87 KaKi87 changed the title Fetch on search by URL Improve the UX of searching for a URL Nov 4, 2024
@BentiGorlich
Copy link
Member

Oh, nice, then I'd like to suggest adding that to the list of unique features in the README (or did I miss the related PR ?).

I don't think that this is special to mbin, but kbin is dead anyways, so maybe it is time to just list what we can do in the readme and website and not what differentiates us from kbin anymore...

@BentiGorlich BentiGorlich added good first issue Good for newcomers backend Backend related issues and pull requests labels Nov 4, 2024
@KaKi87
Copy link
Author

KaKi87 commented Nov 4, 2024

I don't think that this is special to mbin

But Kbin doesn't have this feature, as you can see per the issue I linked.

@BentiGorlich
Copy link
Member

hmm... @melroy89 what do you think?

@melroy89
Copy link
Member

melroy89 commented Nov 4, 2024

I would like to see the readme getting a refresh anyways, so yes please.

The readme should maybe be also be more focused about what Mbin can do in general, since there are a lot of people who didn't knew about kbin at all. So listing the some generic features Mbin can do (as if you would be new to activitypub) would be very helpful. But also these search features mentioned here.

@KaKi87 Feel free to extend the feature list. Remove

Tons of [GUI improvements](https://github.com/MbinOrg/mbin/pulls?q=is%3Apr+is%3Amerged+label%3Afrontend)
    A lot of [enhancements](https://github.com/MbinOrg/mbin/pulls?q=is%3Apr+is%3Amerged+label%3Aenhancement)
    Various [bug fixes](https://github.com/MbinOrg/mbin/pulls?q=is%3Apr+is%3Amerged+label%3Abug)

And replace it with a list of features that make senses for newcomers. You can create a PR.

@KaKi87
Copy link
Author

KaKi87 commented Nov 4, 2024

Feel free to extend the feature list

Oh I have no idea, I don't know much about UX 😅

@melroy89
Copy link
Member

melroy89 commented Nov 4, 2024

Feel free to extend the feature list

Oh I have no idea, I don't know much about UX 😅

I mean extend the readme (markdown) text.

If that is not the case, then the server will put a job in the queue to fetch the post on that url. That is done in the background. So your search result will look empty, when the server is actually getting the post. If you refresh the page ~5 minutes later, the post will be there...

Yeah, so that is definitely a "bug". Or well a bad UX. The search should be a blocking wait, until we have the results and then display them (if the user is logged-in).

@KaKi87
Copy link
Author

KaKi87 commented Nov 4, 2024

I mean extend the readme (markdown) text.

Yes, but I don't know much about how to do that, as in choosing the items and doing the wording, which is a part of UX design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues and pull requests enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants