Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter guild members by rank: exclude "invited" from guild sync! #156

Open
brybrant opened this issue Apr 20, 2024 · 0 comments
Open

Filter guild members by rank: exclude "invited" from guild sync! #156

brybrant opened this issue Apr 20, 2024 · 0 comments

Comments

@brybrant
Copy link
Contributor

Guild sync gives role to people invited (but not yet accepted invite) to a guild.

GW2Bot/guildwars2/guild/sync.py

Line 175 in 9c3c5ff

self.members = {r["name"]: r["rank"] for r in results}

Please filter the array of guild members by rank, excluding any members with the rank invited (in all lowercase) before assigning roles.

(the game forces guild rank names to be capitalized, so this check should not confuse "invited" with "Invited")

Original bug report:
https://discord.com/channels/315519685732990986/315816188938682369/1230523829743521812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brybrant