Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Bootstrap Modal recipe #14

Merged

Conversation

jamiebuilds
Copy link
Contributor

Resolves #13

Changes

  • Add bootstrap to deps
  • Upgraded Marionette to get Behaviors and Channels
  • Added bootstrap/modal recipe

Let me know your thoughts

@jamesplease
Copy link
Member

Cool, @thejameskyle! Thanks for making the PR!

With that said, I don't want this to close out #13, as there are other modal implementations in there I want to study. I'm fine with there being multiple solutions for a given problem in the cookbook. Also, I think @chiplay's solution ties into bootstrap.

jasonLaster added a commit that referenced this pull request May 15, 2014
@jasonLaster jasonLaster merged commit 1a4efc6 into MarionetteLabs:master May 15, 2014
@jamiebuilds jamiebuilds deleted the add-bootstrap-modal-recipe branch May 16, 2014 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Booststrap modal ideas
3 participants