Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicCRP ==> Tools.py ==> opt_weights ==> assert X.notnull().all().all() #60

Open
ghost opened this issue Sep 2, 2021 · 1 comment

Comments

@ghost
Copy link

ghost commented Sep 2, 2021

DynamicCRP no longer works because of an assertion in Tools.py

@Marigold
Copy link
Owner

Marigold commented Sep 9, 2021

That's a safety measure I've added. It turned out dealing with missing values is trickier than I expected (results in unexpected behavior). It's often safer to backfill your data or drop missing values. Do you have any particular use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant