Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for hf token or ask user #8

Open
nsorros opened this issue Oct 27, 2022 · 4 comments
Open

Add config for hf token or ask user #8

nsorros opened this issue Oct 27, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@nsorros
Copy link
Contributor

nsorros commented Oct 27, 2022

Add a command to set HUGGINGFACE_READ_TOKEN. If a config or an environment variable is missing ask the user similar to what wandb tool is doing.

The config command can be later used to set additional information that live in the payload to make it easier to deploy without a json

@nsorros nsorros added the enhancement New feature or request label Oct 27, 2022
@nsorros nsorros changed the title Add config for TOKEN or ask user Add config for hf token or ask user Oct 27, 2022
@nsorros
Copy link
Contributor Author

nsorros commented Dec 9, 2022

maybe what i was describing with hugie configure is more suitable to setting the token @ivyleavedtoadflax. if you agree, i can work on this but we need to think a better command name as configure and config will be confusing

@ivyleavedtoadflax
Copy link
Contributor

Sounds like a great idea, let's think about how best to distinguish this from the configuration that we set for individual inference endpoints.

We can add an alias for config/configuration if it's confusing. But I think this command should be different to the command that is used for setting local configuration.

@nsorros
Copy link
Contributor Author

nsorros commented Dec 12, 2022

Somehow I think that the configuration is tool specific so if we implement both, config or configure should be about this command that sets the token and we would need to rename how we refer to the payload sent to setup the endpoint and same for the command. It could be params.json and a params modify command. It could be that the command can be placed inside endpoint, for example endpoint configure or endpoint params. Let me know your thoughts

@nsorros
Copy link
Contributor Author

nsorros commented May 25, 2023

We should prioritise this. For example I was just describing to Gina how to use the tool and she has to set a variable every time to use it which is not ideal or user friendly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants