-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider merging in optimist_xl #115
Comments
This is awesome work @nanobowers! I am kind of swamped coming back from break, but hopefully I can eyeball this in the coming week. |
Thank you for your patience and thanks for forking this to show us how many of your great ideas work |
@nanobowers If you're up for it, can you make some PRs to get the core functionality of optimist XL into optimist? As you said in the other PR, not every feature in optimist XL is for everyone, but I do believe most features are for everyone. If you can make a PR per feature we can debate those independently, and I would presume most would make it after discussion. |
Alternatively maybe we can resurrect (or redo) #116 . I can't recall what we stalled on...something about chronic gem it seems? |
@Fryguy IIRC I caused a breaking change due to chronic support. I have never been a fan of the hidden "if you happen to have this other gem installed you get completely different behavior" and pulled it into a separate file so one would have to |
Would kindly suggest to merge in the changes in the Optimist_XL gem, which is a feature enhancement fork. Also, it addresses #88 and #97, plus some closed-but-unresolved issues.
https://github.com/nanobowers/optimist_xl
The text was updated successfully, but these errors were encountered: