Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block gestures at bottom #36

Open
6 tasks done
forteller opened this issue Jan 26, 2025 · 2 comments
Open
6 tasks done

Block gestures at bottom #36

forteller opened this issue Jan 26, 2025 · 2 comments
Labels
approved Approved issues enhancement New feature or request extended issues/PRs that related with extended version

Comments

@forteller
Copy link

forteller commented Jan 26, 2025

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for Tubular itself and that requests for adding a new service need to be made in vanilla NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the vanilla NewPipe contribution guidelines.

Feature description

Hi. Thank you for a great tool!

I've recently switched from Tubular, and found the new tempo gesture really useful!

But, for me, it makes my existing wish for a change more pressing than before: I would greatly appreciate if gestures where disabled on a tiny sliver of the bottom part of the player.

Why do you want this feature?

Quite often I watch a video in full screen, but at some point need/want to check out something else, while the video keeps playing. To switch application you need to swipe up from the bottom, but too often this triggers the gesture instead of actually minimize the app, or a combination where the gesture is triggered first then its minimized.

This is annoying enough when the gesture you trigger is volume, but when it's tempo it's even worse, because you can't change that from the minimized state, and need to go back to the app, change it back and then try to minimize it again without triggering the gesture again.

Why ist the feature relevant to this fork?

It seems that NP is having a pause on new features, and this feature is most relevant because of the unique middle gesture area of this fork

Additional information

Just want to mention that the checklist here says "this is a request for Tubular". There's also a typo (ist instead of is) somewhere.

Thanks again!

@asandikci asandikci added enhancement New feature or request approved Approved issues extended issues/PRs that related with extended version labels Jan 26, 2025
@asandikci
Copy link
Member

It would be good to disable gestures at bottom, I agree.
You can disable middle gesture and try to swipe up from middle until this will be implemented

(and yea, there is still lots of Tubular texts inside both app/repo. I'm too lazy to update these. Also Tubular is back so I don't have any reason to quickly re-branding this app)

@forteller
Copy link
Author

Hi, thanks for a very fast and positive reply!

Sure, I could disable the middle gesture, but I really like it! :) Also, I kinda assumed that if I did disable it, the area for the side gestures would expand to fill the whole screen, just like before middle gesture existed. Not sure why I thought that, I've checked now and saw that's not the case. :)

Anyway, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved issues enhancement New feature or request extended issues/PRs that related with extended version
Projects
None yet
Development

No branches or pull requests

2 participants