Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when adding videos to queue from different channel groups after refresh #11

Open
1 task
asandikci opened this issue Dec 18, 2024 · 3 comments
Open
1 task
Labels
needs triage Issue is not yet ready for PR authors to take up

Comments

@asandikci
Copy link
Member

  • needs to be tested with NewPipe/Tubular to know if it is specific to this project

Steps to reproduce

  • select a video from a channel group and start to play it
  • after open another channel group and refresh it (fetch latest videos)
  • select a new(?) video from this group and add it to queue
  • make currently playing video fullscreen (?)
  • exit from fullscreen and back to main menu (while video still playing)
  • app crash

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Country: TR
  • Content Language: en-
  • App Language: en_GB
  • Service: none
  • Version: 0.27.4
  • OS: Linux samsung/on7xrefltedd/on7xreflte:9/PPR1.180610.011/G611FXXU1CSE2:user/release-keys 9 - 28
Crash log

java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.res.Resources android.content.Context.getResources()' on a null object reference
	at android.widget.Toast.makeText(Toast.java:680)
	at org.schabi.newpipe.util.NavigationHelper.enqueueOnPlayer(NavigationHelper.java:192)
	at org.schabi.newpipe.util.NavigationHelper.enqueueOnPlayer(NavigationHelper.java:206)
	at org.schabi.newpipe.info_list.dialog.StreamDialogDefaultEntry.lambda$static$2(StreamDialogDefaultEntry.java:54)
	at org.schabi.newpipe.info_list.dialog.StreamDialogDefaultEntry.$r8$lambda$a5xl77Dbtzjng57a7aWTqc2QHLM(StreamDialogDefaultEntry.java:0)
	at org.schabi.newpipe.info_list.dialog.StreamDialogDefaultEntry$$ExternalSyntheticLambda17.accept(R8$$SyntheticClass:0)
	at org.schabi.newpipe.util.SparseItemUtil.lambda$fetchItemInfoIfSparse$0(SparseItemUtil.java:60)
	at org.schabi.newpipe.util.SparseItemUtil.$r8$lambda$gVp-oj4sCNUa5XRwqzA5fQ53LU0(SparseItemUtil.java:0)
	at org.schabi.newpipe.util.SparseItemUtil$$ExternalSyntheticLambda1.accept(R8$$SyntheticClass:0)
	at org.schabi.newpipe.util.SparseItemUtil.lambda$fetchStreamInfoAndSaveToDatabase$4(SparseItemUtil.java:121)
	at org.schabi.newpipe.util.SparseItemUtil.$r8$lambda$deU_krLKc2Rq-Kx27FrpNhdkTCk(SparseItemUtil.java:0)
	at org.schabi.newpipe.util.SparseItemUtil$$ExternalSyntheticLambda2.accept(R8$$SyntheticClass:0)
	at io.reactivex.rxjava3.internal.observers.ConsumerSingleObserver.onSuccess(ConsumerSingleObserver.java:62)
	at io.reactivex.rxjava3.internal.operators.single.SingleObserveOn$ObserveOnSingleObserver.run(SingleObserveOn.java:81)
	at io.reactivex.rxjava3.android.schedulers.HandlerScheduler$ScheduledRunnable.run(HandlerScheduler.java:123)
	at android.os.Handler.handleCallback(Handler.java:873)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:214)
	at android.app.ActivityThread.main(ActivityThread.java:7127)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:975)


@asandikci
Copy link
Member Author

Is anyone can reproduce this? It sometimes occurs sometimes not. Probably I miss a step.

And is there any similar error on NewPipe/Tubular?

@asandikci asandikci added the needs triage Issue is not yet ready for PR authors to take up label Jan 10, 2025
@whistlingwoods
Copy link

whistlingwoods commented Jan 23, 2025

Yes, it was reported upstream on vanilla NewPipe version 0.24.1 by ktprograms (a developer himself btw). you can take a look on that.
TeamNewPipe/NewPipe#9609

Whether it can be reproduced on PipePipe remains to be seen because PipePipe fork started at codebase of 0.23.3 & never updated to "Refactor player and extract UI components" changes, specially "Create media session UI and fix player notification" in v0.24.0

I have a hunch that this bug belongs to changes post 0.24.0 or 0.24.1 version category. See issues in its release candidate , though most of them were solved but not all of them.

Edited: This issue was definitely not reported there, but it was found 2 releases after that by a tester & power user, a dev himself. If this can be reproduced on any working 0.23.3 versions still around there then maybe but I am saying is wrong.

@whistlingwoods
Copy link

Does this comment helps debugging this?TeamNewPipe/NewPipe#9609 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Issue is not yet ready for PR authors to take up
Projects
None yet
Development

No branches or pull requests

2 participants