Skip to content
This repository has been archived by the owner on Mar 26, 2023. It is now read-only.

MiniTest failing on IO#external_encoding call #380

Open
mmmries opened this issue Mar 20, 2015 · 2 comments
Open

MiniTest failing on IO#external_encoding call #380

mmmries opened this issue Mar 20, 2015 · 2 comments

Comments

@mmmries
Copy link
Contributor

mmmries commented Mar 20, 2015

I tried using minitest with a little puma + sinatra example app and Minitest fails while trying to show failure outputs. I get something like this:

Finished in 0.353042s, 28.3252 runs/s, 0.0000 assertions/s.
during at_exit handler 1: error , NoMethodError: undefined method `external_encoding' for File
a RubySystemExit occurred (error 2752)
topaz 1> exit

It looks to be related to this line in minitest and the method is documented here as part of the ruby 1.9.3 docs.

@zenspider
Copy link
Contributor

Why is this true in maglev?

ENCS = "".respond_to? :encoding

@timfel
Copy link
Member

timfel commented Mar 26, 2015

There was a push to add encoding support, and we thought we had most things stubbed out so the basics (utf8, binary, ascii) work. I would say we missed adding support on files

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants