Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak in substructure branch #262

Open
jackaraz opened this issue Sep 20, 2024 · 0 comments · May be fixed by #13
Open

Memory leak in substructure branch #262

jackaraz opened this issue Sep 20, 2024 · 0 comments · May be fixed by #13
Labels
🐛bug Something isn't working FastJet Issues regarding FastJet ⚙️enhancement New feature or request

Comments

@jackaraz
Copy link
Member

Feature details

Number of jets are set as number of bits instead.

Implementation

Explanation from @mdgoodsell:

I have cracked the problem with the substructure & jets and it is so stupidly simple
I have crawled all over the code, made loads of test edits, etc etc, so at least I think I know how most things work now.

In the end it is because of the

#ifdef MA5_FASTJET_MODE

tags in the RecJetFormat.h & RecJetFormat.cpp
and because there are problems/omissions in the creation of the setup.sh and, most importantly, the setup.csh files: there are still some bugs in those that are being produced, possibly because of python3.12 errors, but in this case you simply don't add the line

setenv FASTJET_FLAG "-DMA5_FASTJET_MODE"
to the setup.csh file, only to the bash one.
so, you need to add

file.write('setenv FASTJET_FLAG "-DMA5_FASTJET_MODE"\n')

to line 154 in setup_writer.py

How important would you say this feature is?

3: Very important! Blocking work.

Additional information

No response

@jackaraz jackaraz added 🐛bug Something isn't working ⚙️enhancement New feature or request FastJet Issues regarding FastJet labels Sep 20, 2024
@jackaraz jackaraz linked a pull request Sep 20, 2024 that will close this issue
2 tasks
BFuks added a commit that referenced this issue Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working FastJet Issues regarding FastJet ⚙️enhancement New feature or request
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant