New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line 162: #43

Open

taspanja opened this issue Aug 10, 2022 · 1 comment

taspanja commented Aug 10, 2022

Hi Guys,

Wow amazing work, just wanted to let you know a couple of things I noticed

On line 162 compare should be against $thumbprint not $certificatethumbprint (99.9% script is still working properly since both the function and $certificatethumbprint are both declared within the code itself.
Regarding null compares null should be placed on left hand side of switch.
Line 344 when converting the $apiresponse string those that have to be specified as plain text?

Member

NickolajA commented Sep 3, 2022

What file are you referencing to on line 162 and respective 344?

Regarding null in conditional statements, I don't agree with the "best practice" approach here, hence why it's the opposite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment